fix Shield link do not re-link after EMP-ed/Disarmed. Need to deploy VERSION{v1.2.7.5} #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r disarmed. This is bug from previous optimization (OPS). It accidentally skipped updates for shieldUnits with NO_LINK (NO_LINK was assigned for EMPed shieldUnits while a table with 1 entry is for lonely shieldUnits)
No logic changes is intended, just renamed functions and encapsulate some stuff.
Closed
GoogleFrog
added a commit
that referenced
this pull request
Jul 23, 2014
fix Shield link do not re-link after EMP-ed/Disarmed. Need to deploy VERSION{v1.2.7.5}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous optimization accidentally skip update of shieldUnit with NO_LINK (this is an EMP-ed shieldUnit).
Also, some rename of some functions to reduce messiness and encapsulated some regularly used task. This is on commit no.2 to not mix it with bug fix.