"Remove Link" option in the right-click context menu for links

CHANGELOG.md

@@ -242,6 +242,10 @@ can always override the language on a per-document basis using the status bar.
   instead of defaulting to "auto"; this allows you to specify the languages of
   your documents instead of relying on LanguageTool to figure it out; may not
   work with more exotic tag variants (such as `de-DE-x-simple-language`)
+- **Feature**: The right-click context menu for external markdown links now 
+  contains the options to "Remove Link". When removing `<link>` style links the
+  `link` text remains as plain text. When removing `[title](link)` style links, 
+  the `title` text remains as plain text.
 - **Change**: The attachment sidebar no longer considers the "open folder" for
   fetching its "other files" -- instead it will use the last focused file's
   folder

source/common/modules/markdown-editor/context-menu/link-image-menu.ts

@@ -19,6 +19,7 @@ import showPopupMenu from '@common/modules/window-register/application-menu-help
 import { type AnyMenuItem } from '@dts/renderer/context'
 import { type SyntaxNode } from '@lezer/common'
 import openMarkdownLink from '../util/open-markdown-link'
+import { removeMarkdownLink } from '../util/remove-markdown-link'
 import { shortenUrlVisually } from '@common/util/shorten-url-visually'
 import makeValidUri from 'source/common/util/make-valid-uri'
 import { pathDirname } from 'source/common/util/renderer-path-polyfill'
@@ -87,6 +88,12 @@ export function linkImageMenu (view: EditorView, node: SyntaxNode, coords: { x:
       enabled: true,
       type: 'normal',
       label: (url.indexOf('mailto:') === 0) ? trans('Copy Mail Address') : trans('Copy Link')
+    },
+    {
+      id: 'menu.remove_link',
+      enabled: true,
+      type: 'normal',
+      label: trans('Remove Link')
     }
   ]
 
@@ -127,6 +134,14 @@ export function linkImageMenu (view: EditorView, node: SyntaxNode, coords: { x:
       })
     } else if (clickedID === 'open-img-in-browser') {
       window.location.href = validAbsoluteURI
+    } else if (clickedID === 'menu.remove_link') {
+      if (node.type.name === 'URL' && node.parent?.type.name === 'Link') {
+        // Handles when user clicks on (url) node in the [text](url) type link
+        removeMarkdownLink(node.parent, view)
+      } else {
+        // Handles when user clicks on [text] part of [text](url) type link or <url> part of <url> type link
+        removeMarkdownLink(node, view)
+      }
     }
   })
 }

source/common/modules/markdown-editor/util/remove-markdown-link.ts

@@ -0,0 +1,58 @@
+/**
+ * @ignore
+ * BEGIN HEADER
+ *
+ * Contains:        removeMarkdownLink function
+ * CVM-Role:        Utility function
+ * Maintainers:     Neil Mazumdar NMazzy
+ *                  Maxwell Bruce MWBruce
+ * License:         GNU GPL v3
+ *
+ * Description:     This function removes a markdown link, performing necessary
+ *                  transformations where applicable.
+ *
+ * END HEADER
+ */
+
+import { type EditorView } from '@codemirror/view'
+import { type ChangeSpec } from '@codemirror/state'
+import { type SyntaxNode } from '@lezer/common'
+import { shortenUrlVisually } from 'source/common/util/shorten-url-visually'
+
+/**
+ * Utility to remove a markdown link. It extracts the text from the markdown
+ * link and replaces the link with just the text.
+ *
+ * @param {EditorView} view - The editor view
+ * @param {SyntaxNode} node - The node containing the Link
+ */
+export function removeMarkdownLink (node: SyntaxNode, view: EditorView): void {
+  const from = node.from
+  const to = node.to
+  var linkText: string
+
+  if (node.type.name === 'URL') {
+    linkText = view.state.sliceDoc(from, to)
+    if ((linkText[0] === '<') && (linkText[linkText.length-1] === '>')) {
+      // This is where the URL with <> formate is parsed
+      // We remove the < > brackets from the link text\
+      const regex = /<([^>]+)>/g
+      const match = regex.exec(linkText)
+      if (match !== null) {
+        linkText = match[1]
+      } else {
+        console.error('Unable to parse <> style URL')
+        return
+      }
+    } else {
+      // LinkText is already a URL
+    }
+  } else {
+    // This is where the URL with []() format is parsed
+    // Using same logic seen in AST Parser to get the text between the []
+    const marks = node.getChildren('LinkMark')
+    linkText = view.state.sliceDoc(marks[0].to, marks[1].from)
+  }
+  const changes: ChangeSpec = { from, to, insert: linkText }
+  view.dispatch({ changes })
+}