Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with NFC reading LUD-17 cards #1213

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Conversation

Talej
Copy link
Contributor

@Talej Talej commented Dec 22, 2022

Description

There was an issue reading Bolt Cards / LUD-17 LNURL NFC where the first 2 characters from the URL were stripped.

This change should allow this format to work while still maintaining previously supported formats.

Note: My NFC cards that I had on hand only supported a maximum of 140 bytes so I wasn't able to test with a bech32 encoded LNURL

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and package-lock.json have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.7.1 milestone Dec 22, 2022
@kaloudis
Copy link
Contributor

Love seeing the initiative here. Code looks clean enough.

Are you using a Boltcard from CoinCorner?

@Talej
Copy link
Contributor Author

Talej commented Dec 22, 2022

Are you using a Boltcard from CoinCorner?

I have tested it with 2 cards - one connected up to CoinCorner and the other through the LNBits Boltcard plugin.

Both using LUD-17 so no bech32 encoding

Copy link
Contributor

@kaloudis kaloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, uTACK

@kaloudis kaloudis merged commit b96ac74 into ZeusLN:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants