Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stores/ChannelsStore: only make calls to pending and closed channels if supported #1370

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

kaloudis
Copy link
Contributor

Description

This caused Sparko interfaces to not be able to load.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Sparko)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using the condition if (BackendUtils.supportsPendingChannels()) two times for calling getCloseChannels and getPendingChannels? Can we use it one time and call both of them inside it? Or can we make a condition separately for calling getCloseChannels like BackendUtils.supportsCloseChannels()

@kaloudis
Copy link
Contributor Author

Why are we using the condition if (BackendUtils.supportsPendingChannels()) two times for calling getCloseChannels and getPendingChannels? Can we use it one time and call both of them inside it? Or can we make a condition separately for calling getCloseChannels like BackendUtils.supportsCloseChannels()

good catch. I think the name is fine for now (if you support one, you'll typically support the other - also confusing if we cram both names in there) but we should put both in the same if block

@kaloudis kaloudis marked this pull request as ready for review March 13, 2023 21:13
@kaloudis kaloudis merged commit c8c1ba2 into ZeusLN:master Mar 14, 2023
@kaloudis kaloudis deleted the get-channels-patch branch March 14, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants