Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Invoices #1374

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Settings: Invoices #1374

merged 2 commits into from
Mar 17, 2023

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Mar 15, 2023

Description

This PR adds a new Invoices settings page for LND users.

Settings view, for LND-based backends
Screenshot_1678854691

Settings view, for non LND-based backends, minus LNDHub
Screenshot_1678859278

Invoices Settings view, for LND-based backends
Screenshot_1678857770

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis force-pushed the settings-invoices branch 2 times, most recently from 5487f33 to 3e4cdd9 Compare March 15, 2023 05:21
@kaloudis kaloudis marked this pull request as ready for review March 15, 2023 05:23
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working perfectly if we ignore this issue for now. Just need to resolve the branch conflicts

@kaloudis kaloudis merged commit 2594140 into ZeusLN:master Mar 17, 2023
@kaloudis kaloudis deleted the settings-invoices branch March 17, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants