-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channels: add announced/unannounced filtering #1584
Channels: add announced/unannounced filtering #1584
Conversation
8a9f249
to
adb7ddc
Compare
Don't sweat the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
tACK - works great and the code is clean @alexlwn123 let's just change the labels to Announced and Unannounced. It would be more consistent with the current language in the app and is more accurate (don't to give users the impression that they're truly private). My bad as I framed it originally as Public/Private filtering. |
8010b7b
to
66cdc1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK. Excellent first contribution to the project!
Description
Note: This is my first time contributing to Zeus, and I'm having trouble getting
tsc
to run. Tried to troubleshoot, but still looking at 350 type errors all across the codebase. These changes aren't causing any additional errors (and I'm stumped), so I'm opening the PR.Thanks!
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: