Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channels: add announced/unannounced filtering #1584

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

alexlwn123
Copy link
Contributor

@alexlwn123 alexlwn123 commented Aug 4, 2023

Description

  • This PR adds filtering options on the channels screen. (Under the search bar)
  • It allows users to filter channels by public/private only.
  • More filtering options can be added trivially.

Note: This is my first time contributing to Zeus, and I'm having trouble getting tsc to run. Tried to troubleshoot, but still looking at 350 type errors all across the codebase. These changes aren't causing any additional errors (and I'm stumped), so I'm opening the PR.

Thanks!

image

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android (emulator - Pixel 3a, Android 14)
  • iOS (emulator - iPhone 14 pro, iOS 16.4)

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@alexlwn123 alexlwn123 force-pushed the filter-public-private-channels branch from 8a9f249 to adb7ddc Compare August 4, 2023 07:10
@kaloudis
Copy link
Contributor

kaloudis commented Aug 4, 2023

Don't sweat the tsc stuff - it needs a reconfiguration

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis
Copy link
Contributor

tACK - works great and the code is clean

@alexlwn123 let's just change the labels to Announced and Unannounced. It would be more consistent with the current language in the app and is more accurate (don't to give users the impression that they're truly private). My bad as I framed it originally as Public/Private filtering.

@alexlwn123 alexlwn123 changed the title Add public/private channel filtering Add announced/unannounced channel filtering Aug 22, 2023
@kaloudis kaloudis changed the title Add announced/unannounced channel filtering Channels: add announced/unannounced filtering Aug 23, 2023
components/Channels/FilterOptions.tsx Outdated Show resolved Hide resolved
@alexlwn123 alexlwn123 force-pushed the filter-public-private-channels branch from 8010b7b to 66cdc1d Compare August 23, 2023 17:01
Copy link
Contributor

@kaloudis kaloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Excellent first contribution to the project!

@kaloudis kaloudis merged commit 8f66f65 into ZeusLN:master Aug 23, 2023
3 checks passed
@alexlwn123 alexlwn123 deleted the filter-public-private-channels branch August 23, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants