CONTACTS #1618

shubhamkmr04 · 2023-08-23T17:32:03Z

No description provided.

…tact input

…r searching contacts

…o contacts

…ltiple addresses' if more than one address is available

kaloudis · 2023-09-07T21:50:30Z

.github/PULL_REQUEST_TEMPLATE.md


 ### Other:

- [ ] Changes were made that require an update to the README
- [ ] Changes were made that require an update to onboarding


why'd this file get changed?

Maybe when I fixed some conflicts, I ran prettier so it is changed

Please undo the change

kaloudis · 2023-09-07T21:50:42Z

nit: change AddContacts.tsx -> AddContact.tsx

kaloudis · 2023-09-07T21:52:40Z

is ContactSettings more accurately named Contacts or ContactList?

shubhamkmr04 · 2023-09-08T14:21:58Z

is ContactSettings more accurately named Contacts or ContactList?

Maybe Contacts would be better

… to 'Contacts'

kaloudis · 2023-09-08T16:33:10Z

ios/zeus.xcodeproj/project.pbxproj

@@ -2022,4 +2022,4 @@
 /* End XCConfigurationList section */
 	};
 	rootObject = 83CBB9F71A601CBA00E9B192 /* Project object */;
-}
+}


this file shouldn't change

kaloudis · 2023-09-08T16:33:29Z

locales/en.json

+    "views.Settings.Contacts.searchBar2": "Search",
+    "views.Settings.Contacts.favorites": "Favorites",
+    "views.Settings.Contacts.contacts": "Contacts",
+    "views.Settings.Contacts.noContacts": "No Contacts",


this file shouldn't remove the LSP strings

Ahh. didn't see that, might have removed them by mistake

kaloudis · 2023-09-08T16:33:56Z

views/Settings/AddContact.tsx

+                underlayColor="transparent"
+            />
+        );
+        const AddPhotos = () => (


nit: space before this line

kaloudis · 2023-09-08T16:34:31Z

views/Settings/Settings.tsx

+                                            color: themeColor('text')
+                                        }}
+                                    >
+                                        Contacts


this should be a locale string

views/Settings/AddContact.tsx

kaloudis · 2023-09-08T16:37:31Z

views/Settings/Contacts.tsx

+                                {localeString(
+                                    'views.Settings.Contacts.favorites'
+                                ).toUpperCase()}{' '}
+                                ({favoriteContacts.length})


let's format this with custom function string formatting

${localeString('views.Settings.Contacts.favorites').toUpperCase() (${favoriteContacts.length})

Giving me syntax error on this one

kaloudis · 2023-09-08T16:37:45Z

views/Settings/Contacts.tsx

+                                {localeString(
+                                    'views.Settings.Contacts.contacts'
+                                ).toUpperCase()}{' '}
+                                ({nonFavoriteContacts.length})


kaloudis · 2023-09-08T16:38:49Z

utils/LinkingUtils.ts

-                console.error(localeString('views.Wallet.Wallet.error'), err)
-            );
+    handleDeepLink = (url: string, navigation: any) => {
+        if (url.startsWith('nostr:')) {


why not add nostr: handling to handleAnything?

kaloudis · 2023-09-13T00:07:39Z

Let's add Nostr deeplinking functionality to NIP-05s too

kaloudis · 2023-09-15T16:26:43Z

views/ContactDetails.tsx

@@ -333,6 +335,50 @@ export default class ContactDetails extends React.Component<
                                        )}
                                    </View>
                                )}
+                            {contact.pubkey.length >= 1 &&


on all these checks we also need to see if contact.x exists. otherwise, things will break if/when we add new fields to the contacts

kaloudis · 2023-09-18T19:17:07Z

tACK

shubhamkmr04 force-pushed the shubham/zeus-contacts branch 2 times, most recently from c986d83 to 33991ce Compare August 25, 2023 08:28

shubhamkmr04 and others added 13 commits August 25, 2023 21:49

Adding functionality for saving Contacts

9ea9020

ContactsSettings: Added search bar

cc76e8a

Contacts on payment + Allowing users saving mulitple values for a con…

7f238ea

…tact input

ContactsSettings: Made the different search bar + Change the logic fo…

855e093

…r searching contacts

Fix UI in Contacts and Send view + Add address selector for sending t…

233c004

…o contacts

Merge branch Pegsasus to shubham/zeus-contacts

02979a4

views: Add ability to have favourite contacts

8296f9e

Using unique id as a identifier for contact objects

fb883aa

AddContacts: Adding validations for input

04af318

Adding tests for 'isValidNpub'

58a56f7

Minor fixes

ef27df1

ContactsSettings: Displaying contacts alphabetically + displaying 'mu…

a71c554

…ltiple addresses' if more than one address is available

Add ability to remove extra fields

1b285d8

shubhamkmr04 force-pushed the shubham/zeus-contacts branch from 0b8b74c to e5386e9 Compare August 26, 2023 13:47

Minor Fixes[2]

73bede2

shubhamkmr04 force-pushed the shubham/zeus-contacts branch from e5386e9 to 73bede2 Compare August 27, 2023 14:56

shubhamkmr04 added 5 commits August 28, 2023 16:11

Add ability to edit contacts

5626747

Saving contacts alphabetically

78ef11b

Merge master to shubham/zeus-contacts

7dbb432

Loading before contact render + Truncating string

81e6575

Add ability to edit photos

4d5e2be

shubhamkmr04 force-pushed the shubham/zeus-contacts branch 2 times, most recently from f31ca0c to 2131fc1 Compare August 30, 2023 15:29

Minor Fixes[3]

053fa07

shubhamkmr04 force-pushed the shubham/zeus-contacts branch from 2131fc1 to 053fa07 Compare August 31, 2023 12:24

Minor Fixes[4]

3ed7e59

shubhamkmr04 force-pushed the shubham/zeus-contacts branch from cb0ac8b to 3ed7e59 Compare September 1, 2023 11:10

Added locale strings

cee68ca

kaloudis reviewed Sep 7, 2023

View reviewed changes

nit: Change 'AddContacts' to 'AddContact' + Change 'ContactsSettings'…

7d345cc

… to 'Contacts'

kaloudis reviewed Sep 8, 2023

View reviewed changes

views/Settings/Settings.tsx Outdated

color: themeColor('text')

}}

>

Contacts

Copy link

Contributor

kaloudis Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a locale string

kaloudis reviewed Sep 8, 2023

View reviewed changes

views/Settings/AddContact.tsx Outdated Show resolved Hide resolved

kaloudis reviewed Sep 8, 2023

View reviewed changes

shubhamkmr04 force-pushed the shubham/zeus-contacts branch 8 times, most recently from 8d0a366 to 531ab1f Compare September 12, 2023 02:17

Minor fixes[6]

711bd31

shubhamkmr04 force-pushed the shubham/zeus-contacts branch from 531ab1f to 711bd31 Compare September 13, 2023 12:27

kaloudis requested changes Sep 15, 2023

View reviewed changes

Adding pubkey in the contact fields

f6c2f6a

shubhamkmr04 force-pushed the shubham/zeus-contacts branch from dd7b0bb to f6c2f6a Compare September 18, 2023 09:43

kaloudis approved these changes Sep 18, 2023

View reviewed changes

kaloudis merged commit 63cb739 into ZeusLN:master Sep 18, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CONTACTS #1618

CONTACTS #1618

shubhamkmr04 commented Aug 23, 2023

kaloudis Sep 7, 2023

shubhamkmr04 Sep 8, 2023

kaloudis Sep 8, 2023

kaloudis commented Sep 7, 2023

kaloudis commented Sep 7, 2023 •

edited

Loading

shubhamkmr04 commented Sep 8, 2023

kaloudis Sep 8, 2023

kaloudis Sep 8, 2023

shubhamkmr04 Sep 11, 2023

kaloudis Sep 8, 2023

kaloudis Sep 8, 2023

kaloudis Sep 8, 2023

shubhamkmr04 Sep 11, 2023

kaloudis Sep 8, 2023

kaloudis Sep 8, 2023

kaloudis commented Sep 13, 2023

kaloudis Sep 15, 2023

kaloudis commented Sep 18, 2023

CONTACTS #1618

CONTACTS #1618

Conversation

shubhamkmr04 commented Aug 23, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaloudis commented Sep 7, 2023

kaloudis commented Sep 7, 2023 • edited Loading

shubhamkmr04 commented Sep 8, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaloudis commented Sep 13, 2023

Choose a reason for hiding this comment

kaloudis commented Sep 18, 2023

kaloudis commented Sep 7, 2023 •

edited

Loading