Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Remove base64 packages #1690

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

myxmaster
Copy link
Contributor

@myxmaster myxmaster commented Sep 23, 2023

Description

  • Moved refactored base64UrlToHex function from MacaroonUtils to Base64Utils
  • Use Base64Utils functions instead of base64-js
  • Refactored Base64Utils functions
  • Added tests
  • Removed now obsolete MacaroonUtils
  • Removed now unused base-64 package
  • Removed now unused base64-js package

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@myxmaster myxmaster changed the title Remove base-64 package Remove base64 packages Sep 23, 2023
@kaloudis
Copy link
Contributor

There are some huge changes here. First and foremost, can you test a disaster recovery from the Embedded node?

@kaloudis kaloudis mentioned this pull request Sep 26, 2023
29 tasks
@kaloudis kaloudis changed the title Remove base64 packages deps: Remove base64 packages Oct 2, 2023
@kaloudis kaloudis merged commit 76aa1b1 into ZeusLN:master Oct 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants