Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POS fixes #2067

Merged
merged 5 commits into from
Mar 21, 2024
Merged

POS fixes #2067

merged 5 commits into from
Mar 21, 2024

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Mar 17, 2024

Description

A user on Telegram reported the following issues regarding the POS:

I'm trying the pos, had issue to set price under 1 euro (ex. have to set 2,10 and then replace the 2 with 0 to have 0,10)

On order summary I had weird amount with a lot of decimals (best to have fixed 2 decimals for euro/dollar)

image

This PR fixes both issues:

  1. Fixed input of sub-1 amounts on the Product Details view
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-03-17.at.16.17.13.mp4
  1. Fixed calculation of display totals on the Order view

simulator_screenshot_2D03F00A-7FD8-4650-8505-6EF641394DE8

This PR also fixes validation of amounts on the Product Details view that include commas instead of decimals, and fixes fiat amounts to two decimals for unit price.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.8.3 milestone Mar 17, 2024
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting some weird behavior

Screen.Recording.2024-03-20.at.6.54.39.PM.mov

@shubhamkmr04
Copy link
Contributor

For the currency having , as a decimal separator like EUR, when we input 5,5 , it is displayed as 5.5 on POS view , which is giving us NaN

@shubhamkmr04
Copy link
Contributor

shubhamkmr04 commented Mar 20, 2024

We shouldn't be allowed to type in the thousand separator of a currency. Like right now, if I type $4,5 it takes in the input and showing me NaN when I select the product

@kaloudis
Copy link
Contributor Author

We shouldn't be allowed to type in the thousand separator of a currency. Like right now, if I type $4,5 it takes in the input and showing me NaN when I select the product

I can't seem to recreate this. Could you post a video?

There may be an issue when rates are not loaded though

@shubhamkmr04
Copy link
Contributor

We shouldn't be allowed to type in the thousand separator of a currency. Like right now, if I type $4,5 it takes in the input and showing me NaN when I select the product

I can't seem to recreate this. Could you post a video?

There may be an issue when rates are not loaded though

Nevermind. Its working as expected now.

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit 8f01311 into ZeusLN:master Mar 21, 2024
3 checks passed
@kaloudis kaloudis deleted the pos-fixes branch March 21, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants