-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POS fixes #2067
POS fixes #2067
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getting some weird behavior
Screen.Recording.2024-03-20.at.6.54.39.PM.mov
For the currency having |
We shouldn't be allowed to type in the thousand separator of a currency. Like right now, if I type $4,5 it takes in the input and showing me NaN when I select the product |
I can't seem to recreate this. Could you post a video? There may be an issue when rates are not loaded though |
Nevermind. Its working as expected now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Description
A user on Telegram reported the following issues regarding the POS:
This PR fixes both issues:
Product Details
viewSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-03-17.at.16.17.13.mp4
Order
viewThis PR also fixes validation of amounts on the
Product Details
view that include commas instead of decimals, and fixes fiat amounts to two decimals for unit price.This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: