-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spotify updates #5
Conversation
The docker compose file should also expose the redirect port ports:
- 28542:28542 I'm currently able to log in to spotify but have problems loading the playlists: Attaching to tidal-utils
tidal-utils | time="2022-06-14T07:53:53Z" level=info msg="Tidal access token is valid."
tidal-utils | time="2022-06-14T07:53:53Z" level=info msg="User mode enabled."
tidal-utils | time="2022-06-14T07:53:53Z" level=debug msg="Getting playlists for Tidal user :upside_down_face:"
tidal-utils | time="2022-06-14T07:53:53Z" level=debug msg="Getting https://listen.tidal.com/v1/users/:upside_down_face:/playlists"
tidal-utils exited with code 0 Gonna try to debug it now EDIT: Also the oauth access requested by the app does only ask for public playlists so the auth token doesn't have the scope to access private playlists. EDIT2: https://github.com/zmb3/spotify/blob/c886435b98ac304491c4e993ecd95988b0a86415/playlist.go#L124-L132 reading a bit in the library code it indeed seems to be some scope related issue. |
I'll take a look at the scopes and see what I can find for private playlists. |
I've added the |
regarding the api scpoe it is working now. But now the program hangs before showing the tidal login url (when starting fresh withouth a tidal login token) |
It was working in VS Code's terminal but couldn't get the link either in a different shell. I just pushed a commit that uses the logging package to show the oauth URLs. |
works great now. |
Thanks for testing my changes! I'll merge this and put out a new release soon. |
This PR includes a non-backwards compatible update with how the application authenticates with Spotify.
Feature request found in #2.
Changes
Notes
Before this PR, Spotify API access was accomplished using an application id and secret allowing an "anonymous" login. Now logging into Spotify requires an authorization flow granting access to tidal-utils. This allows the application to read what playlists you own or have liked.
The new login method allows tidal-utils to convert any playlist you own or have liked automatically without the need to manually enter playlist IDs. For users who prefer to manually enter playlist IDs, it will still be possible by setting a config option.