-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SIGILL error in addEdges
#389
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #389 +/- ##
==========================================
+ Coverage 97.54% 97.55% +0.01%
==========================================
Files 85 85
Lines 9357 9358 +1
==========================================
+ Hits 9127 9129 +2
+ Misses 230 229 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ZigRazor As a way to test the type traits I added an header file containing a list series of static asserts to test all the possible cases. This header is included in |
Also, I've only implemented variadic methods taking pointers to edges/nodes. I thought that it would be sensible to add another taking them by const ref, but that probably should be in another PR. |
Ok, @sbaldu |
This PR:
Node
andEdge
classes containing the type of the template parameteraddEdges
andaddNodes
methods, which produced a SIGILL error (issue [BUG] Illegal Instruction SIGILL in addEgdes_1 #386)