Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SIGILL error in addEdges #389

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Conversation

sbaldu
Copy link
Collaborator

@sbaldu sbaldu commented Jan 11, 2024

This PR:

  • adds a typedef member for the Node and Edge classes containing the type of the template parameter
  • rewrites the type traits for said classes
  • fixes the addEdges and addNodes methods, which produced a SIGILL error (issue [BUG] Illegal Instruction SIGILL in addEgdes_1 #386)
  • add tests for type traits

@ghost
Copy link

ghost commented Jan 11, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@sbaldu sbaldu marked this pull request as draft January 11, 2024 17:23
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1fdcff9) 97.54% compared to head (74ac660) 97.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   97.54%   97.55%   +0.01%     
==========================================
  Files          85       85              
  Lines        9357     9358       +1     
==========================================
+ Hits         9127     9129       +2     
+ Misses        230      229       -1     
Flag Coverage Δ
unittests 97.55% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZigRazor ZigRazor marked this pull request as ready for review January 11, 2024 17:54
@ZigRazor ZigRazor marked this pull request as draft January 11, 2024 17:54
@sbaldu sbaldu marked this pull request as ready for review January 12, 2024 14:43
@sbaldu
Copy link
Collaborator Author

sbaldu commented Jan 12, 2024

@ZigRazor As a way to test the type traits I added an header file containing a list series of static asserts to test all the possible cases. This header is included in GraphTest.cpp and when everything works correctly it is compiled without any errors.
Do you think it's a good way to test it?

@sbaldu
Copy link
Collaborator Author

sbaldu commented Jan 12, 2024

Also, I've only implemented variadic methods taking pointers to edges/nodes. I thought that it would be sensible to add another taking them by const ref, but that probably should be in another PR.

@ZigRazor
Copy link
Owner

Also, I've only implemented variadic methods taking pointers to edges/nodes. I thought that it would be sensible to add another taking them by const ref, but that probably should be in another PR.

Ok, @sbaldu

@ZigRazor ZigRazor merged commit e319dc5 into ZigRazor:master Jan 15, 2024
25 of 29 checks passed
@ZigRazor ZigRazor linked an issue Jan 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Illegal Instruction SIGILL in addEgdes_1
2 participants