Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

feat/getsmartcontractsubstate-batch-request #304

Merged
merged 5 commits into from Jun 2, 2021
Merged

Conversation

teye
Copy link
Contributor

@teye teye commented Jun 2, 2021

Ready for review

  • fix build batch request payloads to support array of array in param fields
  • fix id for batch payloads request to make it dynamic
  • merge with feat: support getSmartContractSubStateBatch batch request branch

@teye teye self-assigned this Jun 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2021

Codecov Report

Merging #304 (232dbc9) into dev (0f0a2bc) will decrease coverage by 0.08%.
The diff coverage is 66.66%.

❗ Current head 232dbc9 differs from pull request most recent head 1e11447. Consider uploading reports for the commit 1e11447 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #304      +/-   ##
==========================================
- Coverage   79.07%   78.99%   -0.09%     
==========================================
  Files          45       45              
  Lines        1826     1833       +7     
  Branches      307      308       +1     
==========================================
+ Hits         1444     1448       +4     
- Misses        381      384       +3     
  Partials        1        1              
Impacted Files Coverage Δ
packages/zilliqa-js-core/src/net.ts 98.63% <ø> (ø)
packages/zilliqa-js-blockchain/src/chain.ts 63.29% <33.33%> (-0.49%) ⬇️
packages/zilliqa-js-core/src/providers/http.ts 92.10% <83.33%> (-2.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f0a2bc...1e11447. Read the comment docs.

@teye teye requested a review from AmritKumar as a code owner June 2, 2021 09:30
@teye teye changed the title fix/batch-request (DONT MERGE FIRST) feat/getsmartcontractsubstate-batch-request Jun 2, 2021
@bb111189 bb111189 merged commit 0d8b1ba into dev Jun 2, 2021
@bb111189 bb111189 deleted the fix/batch-request branch August 18, 2021 05:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants