Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhanced generate accounts, issue #21 #28

Merged
merged 2 commits into from
Mar 1, 2020
Merged

feat: enhanced generate accounts, issue #21 #28

merged 2 commits into from
Mar 1, 2020

Conversation

charliecys
Copy link

  • allow generation of odd number of accounts
  • output more information of the account

renlulu
renlulu reviewed Mar 1, 2020
View reviewed changes
Copy link
Contributor

@renlulu renlulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel like it's more better if we can pass the name of output file in.

@renlulu renlulu merged commit b8269f2 into Zilliqa:dev Mar 1, 2020
@charliecys charliecys deleted the feature/generateAccounts branch March 3, 2020 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renlulu renlulu renlulu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charliecys @renlulu @charlieysc