include node name in error when traversing fails #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I use Syncthing to recursively watch my whole `$HOME`. It fails on the FUSE mount `.gvfs` and this took me *muuuch* to long to figure out. With this change it is much more easy to debug such issues.
mnagel
added a commit
to mnagel/syncthing-inotify
that referenced
this pull request
Mar 31, 2016
the logging lacked the information which was the problematic folder id even though the information is send to the syncthing process. in combination with an upstream fix in notify ( Zillode/notify#2 ) this will make debugging failures much easier as folder id and the failing node (i.e. path) will be part of the error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use Syncthing to recursively watch my whole
$HOME.It fails on the FUSE mount
.gvfsand this took me muuuch to long to figure out.With this change it is much more easy to debug such issues.