ZBUG-3629: fixed handling of image in signature #879
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
An inline image is not included in a reply/forward message when the sender of the original message is added to trusted address.
Root cause:
Source of an image was fetched in the following priority:
dfsrc => data-mce-src => src
Before the fix,
data-mce-src
is set for an image in a signature.<img pnsrc="cid:edf162835aead51e0a185735d5add806ee0b8710@zimbra" data-mce-src="https://HOST/home/ACCOUNT/Briefcase/imageg.png" src="https://HOST/service/home/~/?auth=co&loc=en_US&id=400&part=2.2">
At reply/forward, the url in
data-mce-src
is set insrc
ofimg
tag when a trusted address is configured.Then the image in the forwarded message points the briefcase path. If it is not shared, the image cannot be fetched.
The full access path to a briefcase file is unnecessary for a recipient. The image file is embedded in a message source and referred as cid. The image should always be fetched from the embedded data.
Fix:
data-mce-src
is removed from the image.cid
insrc
is used if it exists.