Added Bed Temperature Settings to help with bed clearing #46
Conversation
… tests), cleaned up looped and item attributes in main class, and streamlined calls to plugin notifier
… for settings page.
… API and hopefully rely more on Jinja templating vs JS html() setting
…sentation server-side and not do lock-step UI updating (for simplicity)
…ironed out bugs; updated UI to separate management from queue clearing
…ms of clear button action
Merge in refactor, UI fixes, etc.
… JSON to allow new users to migrate easily (tested). Added skeleton of per-queueset menu options. Humanized pause time status with other small UI tweaks. Added settings options for handling auto-pause from spaghetti detective.
|
Haven't had a chance to get to catching this project up. Made some time this weekend to work on it. |
# Conflicts: # continuousprint/__init__.py # continuousprint/static/css/continuousprint.css # continuousprint/templates/continuousprint_settings.jinja2 # setup.py
|
I am taking this out of draft and it is ready for review:
If you want to try this on your printer @arcasoy give it a try! |
|
@willindiana I'll be back in town within a few days and def will do, excited to get this running so I can further speed up production. Appreciate the work so far. |
|
@Zinc-OS is there any further considerations I should make to have this considered for a merge? |
|
@willindiana Really appreciate the work u are doing ( I have the issue that M190 R gcode command not really works). How can I install the improved version on my octoprint? I can do some test if u want. |
|
Hey @Ricky-cana I would remove the current install of continuousprint and use the install plugin from URL in octoprint plugin using https://github.com/willindiana/continuousprint/archive/master.zip If or when this change is merged, this step won't be necessary and your settings shouldn't change, but to test this branch you will need to reset your settings. |
|
@willindiana really thanks! I'm gonna test this version during this weekend. I'll keep u updated. |
|
Hey @willindiana , I've tested the plugin for the entire weekend and it works super fine! That's what I needed! The only issue I occurred into is that I have the need to do some commands before the cooldown (I have a switch at the back of the printers and I need to send the bed to the Y0 position). It would be nice to have a sort of script before the cooldown and another just after (or a command to be inserted when the printer should wait to cooldown). |
|
Apologies for not testing it myself, since I've gotten back I can seem to get anything to stick to my new bed. Haven't taken enough time to work out the kinks but will also be testing out as soon as I get to this. One thing that I implemented on my printer which worked great alone but not with ContinuousPrint was the Cooldownfan Plugin. I'm hopeful it will be compatible with this branch since the printer isn't monitoring temp, but it depends on what state the printer is left in when waiting. If not compatible, I'll be tweaking this branch to improve compatibility or even make a new branch that imports those features into this plugin to make ContinuousPrint the all encompassing automation plugin. Let me know if anyone else would be interested in this change. |
|
@Ricky-cana that's great news! Thanks so much for your testing. As for a pre-cooldown script, I think that's an excellent idea. I can put it as an option during the beginning of the cooldown routine before it waits for the bed to meet the target release temperature. I could get that added pretty easily. As for after bed cooldown scripts wouldn't that just fall into the bed clearing routine? Here's my suggested order of things: PRINT FINISHES -> PRE-COOLDOWN SCRIPT RUNS (not implemented yet) -> BED COOLDOWN WAIT -> BED CLEAR SCRIPT IS RUN -> NEXT PRINT IS TRIGGERED Does this meet your needs @Ricky-cana? I would love your input! |
|
@arcasoy I took a look at that plugin and it certainly looks like it would pair nicely with the goal of this project, but as I am not the maintainer of this project @Zinc-OS would have to be the one to give the go-ahead. As for running these plugins independently, I don't see any issues that I should produce through this current implementation. Also if you want to chat further I added you on discord so please give me a ping and we could talk through issues there. |
|
Yes @willindiana it is what I need! Hope that could be useful for other users too. I'll be happy to test it for you |
|
Tested and this update works perfectly to fix the issue that many using this plugin have mentioned: that their printer initiates the bed clearing script before the target temperature associated with the M190 command. I have a few UI/wording suggestions that we can chat over Discord next time you are around @willindiana that I think will help clarify the instructions and clean things up. For example, the default bed clearing script still contains the M190 command, but if you are using the features this PR implemented and edit your desired temperature (i.e. 40 C) without deleting the M190 command (25 C), the printer may still wait after the Pi initiates the bed clearing script. In terms of compatibility with the Cooldownfan plugin, the cooldown fans only initiate when the whole queue is completed, but not in between prints. Initiating them between each print drastically cuts down cycle time for automation, so I'll be digging through that soon. |
|
@Ricky-cana Hey I just implemented your suggested changes for bed cooldown script please test it and let me know your results! I would love any feedback |
|
@willindiana sure I'll test the new version during this weekend. I'll keep u updated in case of issues. Is there the chance to install also the previous "beta" that for the moment works quite fine for me? |
|
@Ricky-cana Using the commit sha from the one you tested: 5b033f1 you should be able to install using this link: https://github.com/willindiana/continuousprint/archive/5b033f1.zip |
|
Hey @willindiana, I tested the new release the whole weekend and seems to be fine! |
|
@willindiana According to https://plugins.octoprint.org/plugins/continuousprint/ it looks like @smartin015 has officially taken over ownership of the project. It looks like the new official repository they are pointing to is now https://github.com/smartin015/continuousprint I hope you find this information helpful. Personally, I can't wait to see your changed merged into the official release. |
|
Hey everyone thank you all very much for your patience in implementing this feature. I have been in conversation with @smartin015 the new owner of continuous print and I will be working on reconciling my changes with his version over the next few days. Keep your eyes peeled on this issue smartin015/continuousprint#6 which is where I will link my latest PR for this feature release. Thanks again everyone for your testing and support. Can't wait for the feature release. |
Some printers don't respect cooldown g-code instructions the way they should. To get around this I implemented a while loop during the clear bed routine that sets the bed temperature to a defined value. Then it waits until the bed hits a defined threshold and then continues to clear the bed. I also added a checkbox in the settings to disable this control which is the default setting so it shouldn't break any compatibility with people who update the plugin.