Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making sure the response dispatched even in case of unhandled error #333

Merged
merged 1 commit into from
May 14, 2024

Conversation

johnyrahul
Copy link
Contributor

@johnyrahul johnyrahul commented May 13, 2024

What

  • Add Generic exception to handle logout for unhandled auth0 excpetions.

Why

  • It need to be logout when auth0 have any exception while trying to get or create organization

How

  • Handled by adding new generic error code

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

  • It Added an error code in the exception handler for the unknown exceptions, So There is no chance to break existing feature.

Database Migrations

  • No migrations

Env Config

Relevant Docs

Related Issues or PRs

Dependencies Versions

Notes on Testing

Screenshots

Checklist

I have read and understood the Contribution Guidelines.

Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@muhammad-ali-e muhammad-ali-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnyrahul johnyrahul marked this pull request as ready for review May 13, 2024 19:25
@nehabagdia nehabagdia merged commit 00aa053 into main May 14, 2024
4 of 5 checks passed
@nehabagdia nehabagdia deleted the fix/user-logout-on-fetch-userorgs branch May 14, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants