Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subobjects are not sortable #140

Closed
DominicBoettger opened this issue Jun 1, 2015 · 5 comments
Closed

Subobjects are not sortable #140

DominicBoettger opened this issue Jun 1, 2015 · 5 comments
Assignees
Milestone

Comments

@DominicBoettger
Copy link

It is not possible to sort field which are in a sub JSON - structure.

Example:

  'header': [
            {
              'key': 'myfield',
              'name': 'MyFIELD'
            },
            {
              'key': 'subjobject.name',
              'name': 'subobject name'
            }]

Click on myfield sorts it correctly.
Click on subobject.name only works once.

Best regards
Dominic

@DominicBoettger DominicBoettger changed the title Subobject are not sortable Subobjects are not sortable Jun 1, 2015
@Zizzamia Zizzamia modified the milestone: Version 0.5.5 Jun 1, 2015
@macem
Copy link

macem commented Jul 6, 2015

I created fix for this, please check macem/ng-tasty-fix@13756fc

@Zizzamia
Copy link
Owner

Zizzamia commented Jul 6, 2015

ThankYou to help me fix this issue. Can you please add test case for this issue. @macem

@Zizzamia Zizzamia added bug and removed investigation labels Jul 6, 2015
@Zizzamia Zizzamia added this to the Version 0.5.7 milestone Jul 6, 2015
@Zizzamia Zizzamia modified the milestones: Version 0.5.8, Version 0.5.7 Jul 26, 2015
@Zizzamia Zizzamia self-assigned this Jul 26, 2015
@Zizzamia Zizzamia modified the milestones: Version 0.5.8, Version 0.6.0 Aug 6, 2015
@ghost
Copy link

ghost commented Aug 6, 2015

Here is a plunker to illustrate this issue with your website exemple: http://plnkr.co/edit/pLSwYOmUgttgy3MWWMEZ

I just relocate "star" and "sf-Location" keys in a metadata object and I link "metadata.star" and "metadata.sf-Location" in headers key.

And I confirm that @macem fix's resolve this issue.

@Zizzamia
Copy link
Owner

Zizzamia commented Aug 6, 2015

@macem can you make a PR with test please.

@Zizzamia Zizzamia modified the milestones: Version 0.6.0, Version 0.6.1, Version 0.6.2 Dec 27, 2015
Zizzamia added a commit that referenced this issue Dec 30, 2015
@Zizzamia
Copy link
Owner

Zizzamia commented Jan 2, 2016

Happy new Year ✨ just released the latest version v0.6.1 of ngTasty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants