Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paramsObj does not match params #153

Closed
InsidersByte opened this issue Jul 23, 2015 · 4 comments
Closed

paramsObj does not match params #153

InsidersByte opened this issue Jul 23, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@InsidersByte
Copy link

paramsObj does not match params

I am using angular resources and it is easier to pass the params object into the get method than build my own search string up. However I noticed that the paramsObj and params do not match. I have attached a screenshot taken today from the demo website.

paramsobjnotmatchingparams

@Zizzamia Zizzamia added the bug label Jul 23, 2015
@Zizzamia Zizzamia added this to the Version 0.5.7 milestone Jul 23, 2015
@Zizzamia Zizzamia self-assigned this Jul 23, 2015
@Zizzamia
Copy link
Owner

What value are not matching? And what page are you watching exactly? Thanks

@Zizzamia Zizzamia modified the milestones: Version 0.5.8, Version 0.5.7 Jul 26, 2015
@InsidersByte
Copy link
Author

I was looking at http://zizzamia.com/ng-tasty/directive/table-server-side/complete.

I was expecting that when you enter a value for the filter by name and/or a filter by location that these values would appear in the paramsObj.

For example I set filter by name to 'a' and filter by location to 'b'.

The resulting params was

sort-by=name&sort-order=dsc&page=1&count=5&name=a&sf-location=b

and the resulting paramsObj was

{"thead":true,"pagination":true,"count":5,"sortBy":"name","sortOrder":"dsc","page":1}

I was hoping that paramsObj would look like this

{"thead":true,"pagination":true,"count":5,"sortBy":"name","sortOrder":"dsc","page":1,"name":"a","sflocation":"b"}

Zizzamia added a commit that referenced this issue Aug 6, 2015
@Zizzamia
Copy link
Owner

Zizzamia commented Aug 6, 2015

ThankYou @InsidersByte to reporting this important bug, I'm releasing right now a new version of #ngTasty with this fix. Please let me know if there are other issue with #ngTasty :-)

@Zizzamia Zizzamia closed this as completed Aug 6, 2015
@InsidersByte
Copy link
Author

Thank you for fixing this so quickly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants