EventItemを作成 #28
Merged
EventItemを作成 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uzimaru0000
commented
Oct 24, 2019
| box-shadow: 0 0 4px 0 rgba(0, 0, 0, 0.1), 0 8px 8px 0 var(--color-black-30); | ||
| } | ||
|
|
||
| /deep/ figure img { |
There was a problem hiding this comment.
ここ、もっといい感じに書きたいけど思い浮かばなかった
There was a problem hiding this comment.
んー俺もこれしか思い浮かばないなー。(,のあと改行するとか？)
| return { | ||
| event: { | ||
| image: 'https://bulma.io/images/placeholders/128x128.png', | ||
| date: 'YYYY/MM/DD hh:mm ~ hh:mm', |
There was a problem hiding this comment.
データを手入力で生成するって言ってたから表示内容をそのまま書いたけど、フォーマットのズレとかで表示がズレるのを避けたいみたいな場合は
start, end みたいなフィールドを作って開始と終わりから計算するようにした方がいいかも？（ただ、手入力だとめんどくさそう）
There was a problem hiding this comment.
そうだねー、そこら辺のデータ管理の仕方は早めに決めたいね。
google form から入力するのはいいと思った。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
resolve #9
Event一覧に使うコンポーネントを作成
変更点
BasicImageのサイズが必ず正方形になってしまうのを修正