feat:Added opacity options on colour highlights #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
pajlada
reviewed
Mar 2, 2024
There was a problem hiding this comment.
The opacity value doesn't have any limits, seems like I can set it to any integer above 0. It should probably be limited to 0-255 (or 1-255) if those are the expected values
It only works with "Square" item highlights & "Convex Hull" NPC highlights, is this intended?
Co-Authored-By: pajlada <962989+pajlada@users.noreply.github.com>
|
Good point on the range, added now! On the highlight choice, you're right in that I think there are some for widgets and such I should check out as well, I'll look into that now. |
|
I realised the existing color config could be configured to also accept opacity as an option, so I've adjusted the PR to try and make use of that, as well as making some useful re-usable functions for the common usage of various opacities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1153