Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix solidity warnings in smart contract template #49

Merged
merged 1 commit into from
May 8, 2018

Conversation

lovesh
Copy link
Contributor

@lovesh lovesh commented Apr 13, 2018

There are warning in code like

  1. Variable is shadowed in inline assembly by an instruction of the same name, this is because Pairing defines functions with names add and mul which conflict assembly.
  2. Function state mutability can be restricted to pure, those functions should be made pure.
  3. Invoking events without "emit" prefix is deprecated., logging events should be done by using emit
  4. The use of non-functional instructions is deprecated. Please use functional notation instead., opcode invalid should be used as invalid()

Signed-off-by: Lovesh Harchandani lovesh.bond@gmail.com

Signed-off-by: Lovesh Harchandani <lovesh.bond@gmail.com>
Copy link
Member

@JacobEberhardt JacobEberhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice, thank you

@JacobEberhardt JacobEberhardt merged commit 4c8fb97 into Zokrates:develop May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants