fix solidity warnings in smart contract template #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are warning in code like
Variable is shadowed in inline assembly by an instruction of the same name
, this is becausePairing
defines functions with namesadd
andmul
which conflict assembly.Function state mutability can be restricted to pure
, those functions should be made pure.Invoking events without "emit" prefix is deprecated.
, logging events should be done by usingemit
The use of non-functional instructions is deprecated. Please use functional notation instead.
, opcodeinvalid
should be used asinvalid()
Signed-off-by: Lovesh Harchandani lovesh.bond@gmail.com