Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

add: foundry integration #166

Merged
merged 10 commits into from
Feb 2, 2023
Merged

Conversation

bahadylbekov
Copy link
Contributor

@bahadylbekov bahadylbekov commented Jan 21, 2023

Hi, we've recently discussed with @emmanuelm41 about adding support for the foundry framework into filecoin-solidity library. As more developers use foundry nowadays and it doesn't have support for npm modules (because foundry uses submodules), it would make integration easier. I recently tried to integrate filecoin-solidity into our foundry-based repo, and it required importing every dependency into the root repo. I hope this PR could improve the integration process. Cheers

🔗 zboto Link

@emmanuelm41
Copy link
Member

emmanuelm41 commented Jan 24, 2023

First of all, thank you so much for the contribution. We really appreciate the effort! We are currently checking internally the process to add new contributors and their work. I will come back soon with some news, but the PR looks great so far!
@bahadylbekov

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2023

CLA assistant check
All committers have signed the CLA.

@emmanuelm41
Copy link
Member

emmanuelm41 commented Feb 1, 2023

@bahadylbekov I am reviewing the PR, and I think it is ok. I have only one question. Is this remapping.txt file necessary for foundry projects? Is the name correct?

@bahadylbekov
Copy link
Contributor Author

bahadylbekov commented Feb 1, 2023

@bahadylbekov I am reviewing the PR, and I think it is ok. I have only one question. Is this remapping.txt file necessary for foundry projects? Is the name correct?

@emmanuelm41 remappings.txt links submodules from the lib folder in a way that doesn't require you to specify the exact path to the module. For example, without remappings an import of CBOR.sol contract from solidity-cborutils module would be like: lib/solidity-cborutils/contracts/CBOR.sol. By having remappings the imports stay the same like here. I hope this helps 🙃

@emmanuelm41 emmanuelm41 merged commit 1fea32e into Zondax:master Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants