Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Various code improvements #249

Merged
merged 8 commits into from
Feb 21, 2023
Merged

Various code improvements #249

merged 8 commits into from
Feb 21, 2023

Conversation

emmanuelm41
Copy link
Member

@emmanuelm41 emmanuelm41 commented Feb 21, 2023

🔗 zboto Link

@emmanuelm41
Copy link
Member Author

Still need to fix account tests

@emmanuelm41 emmanuelm41 marked this pull request as ready for review February 21, 2023 13:19
@emmanuelm41 emmanuelm41 changed the title Use actor id instead of address (bytes) for calling actors Various code improvements Feb 21, 2023
@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25400852
universal_receiver_hook 5150075

Datacap actor

Function Gas
name 6190437
symbol 5936769
total_supply 7963635
balance 7110566
allowance 8172515
transfer 17819995
transfer_from 25470963
burn 11560423
burn_from 18455212
allowance 11457127
increase_allowance 14216988
decrease_allowance 14220185
revoke_allowance 12853436

Init actor

Function Gas
exec 19956821
exec4 7128445

Market actor

Function Gas
add_balance 8147920
withdraw_balance 10970793
get_balance 12304307
get_deal_data_commitment 11443780
get_deal_client 6792848
get_deal_provider 6789352
get_deal_label 11649287
get_deal_term 7359617
get_deal_total_price 8909439
get_deal_client_collateral 8717585
get_deal_provider_collateral 8723765
get_deal_verified 6702422
get_deal_activation 7404061
publish_storage_deals 3089863

Power actor

Function Gas
miner_count 5303254
network_raw_power 5743852
miner_raw_power 7248970
miner_consensus_count 5313802

Precompiles actor

Function Gas
resolve_address 2394758
lookup_delegated_address (empty response) 2312459
lookup_delegated_address (address found) 2399463
resolve_eth_address 2518754

Send actor

Function Gas
send 3517090

Verifreg actor

Function Gas
add_verified_client 13619634
get_claims 10436091
extend_claim_term 11757039
remove_expired_allocations 13387014
remove_expired_claims 11757039

@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25400852
universal_receiver_hook 5150075

Datacap actor

Function Gas
name 6190437
symbol 5936769
total_supply 7963635
balance 7110566
allowance 8172515
transfer 17819995
transfer_from 25470963
burn 11560423
burn_from 18455212
allowance 11457127
increase_allowance 14216988
decrease_allowance 14220185
revoke_allowance 12853436

Init actor

Function Gas
exec 19956821
exec4 7128445

Market actor

Function Gas
add_balance 8147920
withdraw_balance 10970793
get_balance 12304307
get_deal_data_commitment 11443780
get_deal_client 6792848
get_deal_provider 6789352
get_deal_label 11649287
get_deal_term 7359617
get_deal_total_price 8909439
get_deal_client_collateral 8717585
get_deal_provider_collateral 8723765
get_deal_verified 6702422
get_deal_activation 7404061
publish_storage_deals 3089863

Power actor

Function Gas
miner_count 5303254
network_raw_power 5743852
miner_raw_power 7248970
miner_consensus_count 5313802

Precompiles actor

Function Gas
resolve_address 2394758
lookup_delegated_address (empty response) 2312459
lookup_delegated_address (address found) 2399463
resolve_eth_address 2518754

Send actor

Function Gas
send 3517090

Verifreg actor

Function Gas
add_verified_client 13619634
get_claims 10436091
extend_claim_term 11757039
remove_expired_allocations 13387014
remove_expired_claims 11757039

@emmanuelm41 emmanuelm41 merged commit 055f7fb into master Feb 21, 2023
@emmanuelm41 emmanuelm41 deleted the feat/actor-id-as-target branch February 21, 2023 14:14
This was referenced Feb 21, 2023
longfeiWan9 pushed a commit to longfeiWan9/filecoin-solidity that referenced this pull request Mar 7, 2023
* feat: use actor id instead of address (bytes) for calling actors
* fix: make send test cases work again
* feat: feat: use actor id instead of address (bytes) for calling actors
* fix: remove useless methods on test contract
* fix: make miner test work again
* fix: make account actor tests work again
* make universal receiver hook method generic (Zondax#250)
     * feat: make universal receiver hook method generic
     * re run CI
* fix CI on master branch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider dropping support for call_actor_id Fix CI in master branch
1 participant