Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

create custom errors for different scenarios #307

Merged
merged 4 commits into from
Feb 24, 2023
Merged

create custom errors for different scenarios #307

merged 4 commits into from
Feb 24, 2023

Conversation

emmanuelm41
Copy link
Member

@emmanuelm41 emmanuelm41 commented Feb 24, 2023 •
edited by zboto bot
Loading

closes #280

🔗 zboto Link

@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25101498
universal_receiver_hook 4806689

Datacap actor

Function Gas
name 5700361
symbol 5446693
total_supply 7473666
balance 6620026
allowance 7682103
transfer 17330221
transfer_from 24980949
burn 11070650
burn_from 17965290
allowance 10966490
increase_allowance 13726479
decrease_allowance 13729676
revoke_allowance 12362799

Init actor

Function Gas
exec 19414989
exec4 6609345

Market actor

Function Gas
publish_storage_deals 49089592
add_balance 7590504
withdraw_balance 10429001
get_balance 11754717
get_deal_data_commitment 10893788
get_deal_client 6242687
get_deal_provider 6239191
get_deal_label 11099006
get_deal_term 6809409
get_deal_total_price 8359901
get_deal_client_collateral 8168048
get_deal_provider_collateral 8174228
get_deal_verified 6152261
get_deal_activation 6853853

Power actor

Function Gas
miner_count 4760145
network_raw_power 5200575
miner_raw_power 6705889
miner_consensus_count 4770693

Precompiles actor

Function Gas
resolve_address 2411070
lookup_delegated_address (empty response) 2328771
lookup_delegated_address (address found) 2415775
resolve_eth_address 2439194

Send actor

Function Gas
send (actor id) 3276905
send (address) 3276905

Verifreg actor

Function Gas
add_verified_client 13206577
get_claims 9999795
extend_claim_term 11320671
remove_expired_allocations 12950983
remove_expired_claims 11320671

@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25072088
universal_receiver_hook 4795404

Datacap actor

Function Gas
name 5699645
symbol 5445977
total_supply 7472950
balance 6619310
allowance 7681387
transfer 17329505
transfer_from 24980233
burn 11069934
burn_from 17964574
allowance 10965774
increase_allowance 13725763
decrease_allowance 13728960
revoke_allowance 12362083

Init actor

Function Gas
exec 19413389
exec4 6607745

Market actor

Function Gas
publish_storage_deals 49078182
add_balance 7560968
withdraw_balance 10417590
get_balance 11743307
get_deal_data_commitment 10882377
get_deal_client 6231277
get_deal_provider 6227781
get_deal_label 11087596
get_deal_term 6797998
get_deal_total_price 8348491
get_deal_client_collateral 8156638
get_deal_provider_collateral 8162818
get_deal_verified 6140851
get_deal_activation 6842442

Power actor

Function Gas
miner_count 4760145
network_raw_power 5200575
miner_raw_power 6705889
miner_consensus_count 4770693

Precompiles actor

Function Gas
resolve_address 2411070
lookup_delegated_address (empty response) 2328771
lookup_delegated_address (address found) 2415775
resolve_eth_address 2439194

Send actor

Function Gas
send (actor id) 3242070
send (address) 3242070

Verifreg actor

Function Gas
add_verified_client 13178031
get_claims 9989375
extend_claim_term 11310251
remove_expired_allocations 12940563
remove_expired_claims 11310251

@emmanuelm41 emmanuelm41 merged commit 7911f4c into master Feb 24, 2023
@emmanuelm41 emmanuelm41 deleted the feat/error-handling branch February 24, 2023 17:39
@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25071900
universal_receiver_hook 4795216

Datacap actor

Function Gas
name 5699109
symbol 5445441
total_supply 7472414
balance 6618774
allowance 7680851
transfer 17328969
transfer_from 24979697
burn 11069398
burn_from 17964038
allowance 10965238
increase_allowance 13725227
decrease_allowance 13728424
revoke_allowance 12361547

Init actor

Function Gas
exec 19414457
exec4 6608813

Market actor

Function Gas
publish_storage_deals 49079734
add_balance 7562520
withdraw_balance 10419142
get_balance 11744859
get_deal_data_commitment 10883929
get_deal_client 6232829
get_deal_provider 6229333
get_deal_label 11089148
get_deal_term 6799550
get_deal_total_price 8350043
get_deal_client_collateral 8158190
get_deal_provider_collateral 8164370
get_deal_verified 6142403
get_deal_activation 6843994

Power actor

Function Gas
miner_count 4761077
network_raw_power 5201507
miner_raw_power 6706821
miner_consensus_count 4771625

Precompiles actor

Function Gas
resolve_address 2411070
lookup_delegated_address (empty response) 2328771
lookup_delegated_address (address found) 2415775
resolve_eth_address 2439194

Send actor

Function Gas
send (actor id) 3241986
send (address) 3241986

Verifreg actor

Function Gas
add_verified_client 13176827
get_claims 9988171
extend_claim_term 11309047
remove_expired_allocations 12939359
remove_expired_claims 11309047

longfeiWan9 pushed a commit to longfeiWan9/filecoin-solidity that referenced this pull request Mar 7, 2023
@emmanuelm41 @longfeiWan9
create custom errors for different scenarios (Zondax#307)
de912da 
* feat: create custom errors for different scenarios
* feat: add inline comments and use custom errors in more places
* feat: add more inline comments to lib
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

./utils/Actor.sol error handling
1 participant
@emmanuelm41