Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

create FilActorId type to replace generic uint64 #313

Merged
merged 3 commits into from
Feb 25, 2023

Conversation

emmanuelm41
Copy link
Member

@emmanuelm41 emmanuelm41 commented Feb 25, 2023

closes #310

🔗 zboto Link

@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25097408
universal_receiver_hook 4820725

Miner actor

Function Gas
change_owner_address 7448705
get_beneficiary 9817039
change_beneficiary 8748094
get_owner 7425911
get_available_balance 5899316
get_vesting_funds 6102948
repay_debt 6342946
confirm_change_worker_address 6252084
get_peer_id 6537212
get_multiaddresses 7061531
change_worker_address 8933823
is_controlling_address 6523349
get_sector_size 5814223
change_multiaddresses 8047886
change_peer_id 7624009
withdraw_balance 8462292

Datacap actor

Function Gas
name 5702800
symbol 5456236
total_supply 7468993
balance 6691211
allowance 7828502
transfer 17421483
transfer_from 25140129
burn 10914297
burn_from 18071380
allowance 11116353
increase_allowance 13831409
decrease_allowance 13823442
revoke_allowance 12379179

Init actor

Function Gas
exec 19750022
exec4 6769021

Market actor

Function Gas
publish_storage_deals 49329517
add_balance 7597058
withdraw_balance 10379211
get_balance 11786664
get_deal_data_commitment 10846625
get_deal_client 6133341
get_deal_provider 6133393
get_deal_label 10944097
get_deal_term 6776462
get_deal_total_price 8216453
get_deal_client_collateral 8035259
get_deal_provider_collateral 8030779
get_deal_verified 6053499
get_deal_activation 6810246

Power actor

Function Gas
miner_count 4791344
network_raw_power 5231774
miner_raw_power 6740644
miner_consensus_count 4805448

Precompiles actor

Function Gas
resolve_address 2512561
lookup_delegated_address (empty response) 2335624
lookup_delegated_address (address found) 2422628
resolve_eth_address 2446047

Send actor

Function Gas
send (actor id) 3277438
send (address) 3591742

Verifreg actor

Function Gas
add_verified_client 13277275
get_claims 10014644
extend_claim_term 11335520
remove_expired_allocations 12965832
remove_expired_claims 11335520

@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25095192
universal_receiver_hook 4818509

Miner actor

Function Gas
change_owner_address 7448813
get_beneficiary 9817147
change_beneficiary 8748202
get_owner 7426019
get_available_balance 5899424
get_vesting_funds 6103056
repay_debt 6343054
confirm_change_worker_address 6252192
get_peer_id 6537320
get_multiaddresses 7061639
change_worker_address 8933931
is_controlling_address 6523457
get_sector_size 5814331
change_multiaddresses 8047994
change_peer_id 7624117
withdraw_balance 8462400

Datacap actor

Function Gas
name 5700852
symbol 5454288
total_supply 7467045
balance 6689263
allowance 7826554
transfer 17419535
transfer_from 25138181
burn 10912349
burn_from 18069432
allowance 11114405
increase_allowance 13829461
decrease_allowance 13821494
revoke_allowance 12377231

Init actor

Function Gas
exec 19749570
exec4 6768569

Market actor

Function Gas
publish_storage_deals 49371944
add_balance 7601020
withdraw_balance 10383174
get_balance 11790627
get_deal_data_commitment 10850588
get_deal_client 6137303
get_deal_provider 6137355
get_deal_label 10948059
get_deal_term 6780425
get_deal_total_price 8220415
get_deal_client_collateral 8039222
get_deal_provider_collateral 8034742
get_deal_verified 6057461
get_deal_activation 6814209

Power actor

Function Gas
miner_count 4791344
network_raw_power 5231774
miner_raw_power 6740644
miner_consensus_count 4805448

Precompiles actor

Function Gas
resolve_address 2512561
lookup_delegated_address (empty response) 2335624
lookup_delegated_address (address found) 2422628
resolve_eth_address 2446047

Send actor

Function Gas
send (actor id) 3277438
send (address) 3591742

Verifreg actor

Function Gas
add_verified_client 13286892
get_claims 10046749
extend_claim_term 11444553
remove_expired_allocations 12982945
remove_expired_claims 11444553

@emmanuelm41 emmanuelm41 merged commit 318295c into master Feb 25, 2023
@emmanuelm41 emmanuelm41 deleted the fet/fil-actor-id-type branch February 25, 2023 20:30
@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25095648
universal_receiver_hook 4818965

Miner actor

Function Gas
change_owner_address 7449425
get_beneficiary 9817759
change_beneficiary 8748814
get_owner 7426631
get_available_balance 5900036
get_vesting_funds 6103668
repay_debt 6343666
confirm_change_worker_address 6252804
get_peer_id 6537932
get_multiaddresses 7062251
change_worker_address 8934543
is_controlling_address 6524069
get_sector_size 5814943
change_multiaddresses 8048606
change_peer_id 7624729
withdraw_balance 8463012

Datacap actor

Function Gas
name 5701200
symbol 5454636
total_supply 7467393
balance 6689611
allowance 7826902
transfer 17419883
transfer_from 25138529
burn 10912697
burn_from 18069780
allowance 11114753
increase_allowance 13829809
decrease_allowance 13821842
revoke_allowance 12377579

Init actor

Function Gas
exec 19750022
exec4 6769021

Market actor

Function Gas
publish_storage_deals 49372504
add_balance 7601580
withdraw_balance 10383734
get_balance 11791187
get_deal_data_commitment 10851148
get_deal_client 6137863
get_deal_provider 6137915
get_deal_label 10948619
get_deal_term 6780985
get_deal_total_price 8220975
get_deal_client_collateral 8039782
get_deal_provider_collateral 8035302
get_deal_verified 6058021
get_deal_activation 6814769

Power actor

Function Gas
miner_count 4791344
network_raw_power 5231774
miner_raw_power 6740644
miner_consensus_count 4805448

Precompiles actor

Function Gas
resolve_address 2512561
lookup_delegated_address (empty response) 2335624
lookup_delegated_address (address found) 2422628
resolve_eth_address 2446047

Send actor

Function Gas
send (actor id) 3277438
send (address) 3591742

Verifreg actor

Function Gas
add_verified_client 13285796
get_claims 10045653
extend_claim_term 11443457
remove_expired_allocations 12981849
remove_expired_claims 11443457

longfeiWan9 pushed a commit to longfeiWan9/filecoin-solidity that referenced this pull request Mar 7, 2023
* create FilActorId type to replace generic uint64
* convert more uint64  to FilActorId
* add some inline comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uint64 for actor id made into its own type
1 participant