Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Fix comment #361

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Fix comment #361

merged 2 commits into from
Apr 12, 2023

Conversation

orenyomtov
Copy link
Contributor

@orenyomtov orenyomtov commented Apr 1, 2023 •
edited by zboto bot
Loading

🔗 zboto Link

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rllola
Copy link
Contributor

rllola commented Apr 10, 2023

Hey @orenyomtov
Could give me some more context for this change ?

@orenyomtov
Copy link
Contributor Author

If I'm not mistaken, the original comment was wrong, so I fixed it

The precompile by default calls the actor, and does not delegate call it

@rllola
Copy link
Contributor

rllola commented Apr 10, 2023

We do use delegated call opcode for it so we are doing a delegated call like the comment originally mentioned.

@orenyomtov
Copy link
Contributor Author

Yeah you always delegatecall to the precompile, and then the precompile either calls or static-calls, depending on the flag provided

@rllola
Copy link
Contributor

rllola commented Apr 12, 2023

Ah yes indeed you are right! Nice lets get this merge.

@rllola rllola merged commit 478e982 into Zondax:master Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rllola rllola rllola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orenyomtov @CLAassistant @rllola