Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When writing MP4 sample, save buffer.size() into a temporary variable #2628

Merged
merged 1 commit into from
Jun 1, 2019
Merged

When writing MP4 sample, save buffer.size() into a temporary variable #2628

merged 1 commit into from
Jun 1, 2019

Conversation

arrowd
Copy link
Contributor

@arrowd arrowd commented Jun 1, 2019

This is a fix for #2403

After a lot of debugging it turned out that after calling buffer.extract(), the buffer.size() method starts to return 0, which is then passed to mp4v2.

@abishai
Copy link
Contributor

abishai commented Jun 1, 2019

Confirming, container has track with data

Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '/var/db/zoneminder/events/12/2019-06-01/248225/248225-video.mp4':
  Metadata:
    major_brand     : mp42
    minor_version   : 0
    compatible_brands: mp42isom
    creation_time   : 2019-06-01T20:10:00.000000Z
  Duration: 00:09:59.94, start: 0.472000, bitrate: 6305 kb/s
    Stream #0:0(und): Video: h264 (Main) (avc1 / 0x31637661), yuv420p, 1280x1024, 6304 kb/s, 5 fps, 1k tbr, 1k tbn, 2k tbc (default)
    Metadata:
      creation_time   : 2019-06-01T20:10:00.000000Z
      encoder         : JVT/AVC Coding

@connortechnology
Copy link
Member

Nice find!

@connortechnology connortechnology merged commit 1d132b5 into ZoneMinder:master Jun 1, 2019
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Jun 2, 2019
multimedia/zoneminder: Fix MP4 file generation by patching UB bug in …
7f5ab47 
…src/zm_video.cpp file.

The patch has also been merged upstream: ZoneMinder/zoneminder#2628

Reviewed by:	abi@abinet.ru (maintainer)
Approved by:	tcberner (mentor, implicit)


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@503283 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Jun 2, 2019
@arrowd
multimedia/zoneminder: Fix MP4 file generation by patching UB bug in …
219ab9f 
…src/zm_video.cpp file.

The patch has also been merged upstream: ZoneMinder/zoneminder#2628

Reviewed by:	abi@abinet.ru (maintainer)
Approved by:	tcberner (mentor, implicit)
tota pushed a commit to tota/freebsd-ports that referenced this pull request Jun 2, 2019
multimedia/zoneminder: Fix MP4 file generation by patching UB bug in …
13ddc14 
…src/zm_video.cpp file.

The patch has also been merged upstream: ZoneMinder/zoneminder#2628

Reviewed by:	abi@abinet.ru (maintainer)
Approved by:	tcberner (mentor, implicit)


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@503283 35697150-7ecd-e111-bb59-0022644237b5
Jehops pushed a commit to Jehops/freebsd-ports-legacy that referenced this pull request Jun 2, 2019
@arrowd
multimedia/zoneminder: Fix MP4 file generation by patching UB bug in …
c577f71 
…src/zm_video.cpp file.

The patch has also been merged upstream: ZoneMinder/zoneminder#2628

Reviewed by:	abi@abinet.ru (maintainer)
Approved by:	tcberner (mentor, implicit)


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@503283 35697150-7ecd-e111-bb59-0022644237b5
@connortechnology
Copy link
Member

This also seems to have fixed x264 encoding on arm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arrowd @abishai @connortechnology