fix(layout): auto sidebar footer height #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
evad1n,
goodpickle,
nick-lanners and
Thienhuynh95
evad1n
previously approved these changes
May 6, 2024
Explore will be okay. Arrakis will just need the footer children height set. Not sure if any other projects use the layout? Maybe I'll set it as a min height of this weird calculation. |
|
I reverted thinking a |
evad1n
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear issue
Description
This PR removes the strict height on the amino Layout footer. Not sure why it was necessary in the first place? 🤔
I'm adding a new piece to the dashboard sidebar footer and this is what I need done.
Todo