Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GET /processors #186

Closed
enudler opened this issue Aug 5, 2019 · 8 comments
Closed

Implement GET /processors #186

enudler opened this issue Aug 5, 2019 · 8 comments
Assignees
@syncush
Labels
1.2.0 enhancement New feature or request

Comments

@enudler
Copy link
Collaborator

enudler commented Aug 5, 2019

No description provided.

@enudler enudler added enhancement New feature or request 1.2.0 CustomJSPhase2 labels Aug 5, 2019
@syncush
Copy link
Collaborator

syncush commented Aug 8, 2019

Should it return all the stored files in one response object or maybe it should be implemented as a scroll?
The response can get really "big" (tbh not that big but just for the sake of best practice)

@enudler
Copy link
Collaborator Author

enudler commented Aug 8, 2019

hi @syncush
it's always good practice to support paging.
one way to do it is to have query params
from: integer (default 0)
limit: integer

@syncush
Copy link
Collaborator

syncush commented Aug 9, 2019 •
edited
Loading

Sound good to me!

@enudler
Copy link
Collaborator Author

enudler commented Aug 9, 2019

Sounds good but according to what api?

@syncush
Copy link
Collaborator

syncush commented Aug 9, 2019 •
edited
Loading

As of now, I am working on the GET /processors, therefore, the API for this specific route is pretty straight forward, in addition, I am learning my way through Predator's backend because there are packages(like sequelize and express-ajv-swagger-validation) I have never used before.

but I am working on the C.R.U.D issues.

maybe it was an overstatement, but my main goal right now is to be able to contribute to Predator's backend code, I'll edit my previous comment.

@enudler
Copy link
Collaborator Author

enudler commented Aug 9, 2019

hi @syncush
Your contribution is very welcome. just wanted to make sure crud is compatible with the API which is not yet ready
I will try to purpose a bit later today API for the processor's resource and create a dedicated slack channel in our workspace to discuss this feature.

@enudler enudler assigned enudler and syncush and unassigned enudler Aug 9, 2019
@syncush
Copy link
Collaborator

syncush commented Aug 9, 2019

Thank you 😊

just wanted to make sure crud is compatible with the API which is not yet ready

I totally agree that an API should be defined first.

@enudler
Copy link
Collaborator Author

enudler commented Aug 9, 2019

To anyone who is not in slack here is the API proposal:
#200

@syncush syncush mentioned this issue Oct 12, 2019
Merged
syncush added a commit to syncush/predator that referenced this issue Oct 26, 2019
@syncush
test(processors): add tests for GET /processors (Zooz#186)
294021b
syncush added a commit to syncush/predator that referenced this issue Oct 26, 2019
@syncush
test(processors): add tests for GET /processors (Zooz#186)
e365c2d
NivLipetz pushed a commit that referenced this issue Nov 2, 2019
@syncush @NivLipetz
feat(custom-js): implement GET /processors (#212)
06a2cb3 
* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* feat(custom-js): implement GET /processors (Sequelize only)

* test(processors): add tests for GET /processors (#186)

* feat(custom-js): implement GET /processors (cassandra)

* test(processors): add unit-tests for insertProcessor
NivLipetz pushed a commit that referenced this issue Nov 9, 2019
@syncush @NivLipetz
feat(custom-js): implement GET /processors (#212)
16a2ce3 
* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* feat(custom-js): implement GET /processors (Sequelize only)

* test(processors): add tests for GET /processors (#186)

* feat(custom-js): implement GET /processors (cassandra)

* test(processors): add unit-tests for insertProcessor
NivLipetz pushed a commit that referenced this issue Nov 10, 2019
@syncush @NivLipetz
feat(custom-js): implement DELETE /processors/{processor_id} (#231)
00850cd 
* feat(api): add api spec for processors resource

closes #185

fix #185

* feat(api): add api spec for processors resource (#200)

* feat(api): add api spec for processors resource

* fix(typo): typo date_time to date-time

* fix(typo): typo date_time to date-time

* chore(openapi3): code review comments addressed

* docs(api): add download endpoint for processor files

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* chore: fix rebase to master

* WIP: feat(custom-js): implement POST /processors (#213)

* docs(image): fix outdated image in docs (#214)

* chore(ci/cd): remove circleci docker_layer_caching (#218)

* feat(api): add api spec for processors resource (#200)

* feat(api): add api spec for processors resource

* feat(api): add api spec for processors resource

closes #185

fix #185

* fix(typo): typo date_time to date-time

* fix(typo): typo date_time to date-time

* chore(openapi3): code review comments addressed

* docs(api): add download endpoint for processor files

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* chore: fix rebase to master

* feat(custom-js): implement POST /processors

* test(processors): add tests for POST /processors (#217)

* test(processors): add tests for POST /processors

* style(processors): fix processors cassandra connector name

* feat(processors): add js validation on POST /processors

* fix(processors): add updated_at/created_at to processors resource

* test(processors): add validateJavascriptContent unit-tests

* test(create-test): fix processor file download error message in test

* feat(custom-js): implement GET /processors (#212)

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* feat(custom-js): implement GET /processors (Sequelize only)

* test(processors): add tests for GET /processors (#186)

* feat(custom-js): implement GET /processors (cassandra)

* test(processors): add unit-tests for insertProcessor

* feat(custom-js): implement DELETE /processors/{processor_id}

* feat(custom-js): implement DELETE /processors/{processor_id}
NivLipetz pushed a commit that referenced this issue Nov 20, 2019
@syncush @NivLipetz
feat(custom-js): implement GET /processors (#212)
6a00cd7 
* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* feat(custom-js): implement GET /processors (Sequelize only)

* test(processors): add tests for GET /processors (#186)

* feat(custom-js): implement GET /processors (cassandra)

* test(processors): add unit-tests for insertProcessor
NivLipetz pushed a commit that referenced this issue Nov 20, 2019
@syncush @NivLipetz
feat(custom-js): implement DELETE /processors/{processor_id} (#231)
8b2d9d0 
* feat(api): add api spec for processors resource

closes #185

fix #185

* feat(api): add api spec for processors resource (#200)

* feat(api): add api spec for processors resource

* fix(typo): typo date_time to date-time

* fix(typo): typo date_time to date-time

* chore(openapi3): code review comments addressed

* docs(api): add download endpoint for processor files

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* chore: fix rebase to master

* WIP: feat(custom-js): implement POST /processors (#213)

* docs(image): fix outdated image in docs (#214)

* chore(ci/cd): remove circleci docker_layer_caching (#218)

* feat(api): add api spec for processors resource (#200)

* feat(api): add api spec for processors resource

* feat(api): add api spec for processors resource

closes #185

fix #185

* fix(typo): typo date_time to date-time

* fix(typo): typo date_time to date-time

* chore(openapi3): code review comments addressed

* docs(api): add download endpoint for processor files

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* chore: fix rebase to master

* feat(custom-js): implement POST /processors

* test(processors): add tests for POST /processors (#217)

* test(processors): add tests for POST /processors

* style(processors): fix processors cassandra connector name

* feat(processors): add js validation on POST /processors

* fix(processors): add updated_at/created_at to processors resource

* test(processors): add validateJavascriptContent unit-tests

* test(create-test): fix processor file download error message in test

* feat(custom-js): implement GET /processors (#212)

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* feat(custom-js): implement GET /processors (Sequelize only)

* test(processors): add tests for GET /processors (#186)

* feat(custom-js): implement GET /processors (cassandra)

* test(processors): add unit-tests for insertProcessor

* feat(custom-js): implement DELETE /processors/{processor_id}

* feat(custom-js): implement DELETE /processors/{processor_id}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syncush syncush

Labels
1.2.0 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@enudler @syncush @NivLipetz