feat(custom-js): implement GET /processors/{processor_id} #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NivLipetz
force-pushed
the
get-processor
branch
from
05e73b1
to
fb2af4a
Compare
NivLipetz
force-pushed
the
customjsphase2
branch
from
06a2cb3
to
16a2ce3
Compare
* docs(image): fix outdated image in docs (#214) * chore(ci/cd): remove circleci docker_layer_caching (#218) * feat(api): add api spec for processors resource (#200) * feat(api): add api spec for processors resource * feat(api): add api spec for processors resource closes #185 fix #185 * fix(typo): typo date_time to date-time * fix(typo): typo date_time to date-time * chore(openapi3): code review comments addressed * docs(api): add download endpoint for processor files * chore(dependencies): update cassandra-driver to v4.1.0 (#210) * chore: fix rebase to master * feat(custom-js): implement POST /processors * test(processors): add tests for POST /processors (#217) * test(processors): add tests for POST /processors * style(processors): fix processors cassandra connector name * feat(processors): add js validation on POST /processors * fix(processors): add updated_at/created_at to processors resource * test(processors): add validateJavascriptContent unit-tests * test(create-test): fix processor file download error message in test
NivLipetz
force-pushed
the
get-processor
branch
from
2e4fef0
to
75562e5
Compare
syncush
reviewed
Nov 9, 2019
syncush
approved these changes
Nov 9, 2019
NivLipetz
added a commit
that referenced
this pull request
Nov 20, 2019
* WIP: feat(custom-js): implement POST /processors (#213) * docs(image): fix outdated image in docs (#214) * chore(ci/cd): remove circleci docker_layer_caching (#218) * feat(api): add api spec for processors resource (#200) * feat(api): add api spec for processors resource * feat(api): add api spec for processors resource closes #185 fix #185 * fix(typo): typo date_time to date-time * fix(typo): typo date_time to date-time * chore(openapi3): code review comments addressed * docs(api): add download endpoint for processor files * chore(dependencies): update cassandra-driver to v4.1.0 (#210) * chore: fix rebase to master * feat(custom-js): implement POST /processors * test(processors): add tests for POST /processors (#217) * test(processors): add tests for POST /processors * style(processors): fix processors cassandra connector name * feat(processors): add js validation on POST /processors * fix(processors): add updated_at/created_at to processors resource * test(processors): add validateJavascriptContent unit-tests * test(create-test): fix processor file download error message in test * feat(custom-js): implement GET /processors/{processor_id} * test(custom-js): add tests for GET /processors/{processor_id}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.