Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error msg icon2 #1141

Merged
merged 7 commits into from
Aug 19, 2024
Merged

Error msg icon2 #1141

merged 7 commits into from
Aug 19, 2024

Conversation

gbkr
Copy link
Contributor

@gbkr gbkr commented Aug 19, 2024

New icon for ErrorMessage

Screenshot 2024-08-19 at 16 02 11

@gbkr gbkr requested a review from a team as a code owner August 19, 2024 15:13
Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: 5760966

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@zopauk/react-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

👋 Hey there!

Thank you for you contribution. Below is a preview of the release notes if your PR gets merged.
Please, make sure it includes all your significant changes with descriptive messages.
Keep in mind that release notes are automatically generated from the commit messages.
More info in the contribution section.


5.70.0 (2024-08-19)

Bug Fixes

Features

  • add NabarLite (da8388a)
  • allow different icon variants in ErrorMessage (d2d86d8)
  • new icon type (f3d26b6)
  • update @types/react to latest (368812c)

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for zrc ready!

Name Link
🔨 Latest commit 5760966
🔍 Latest deploy log https://app.netlify.com/sites/zrc/deploys/66c3687b86990b0008b1fb25
😎 Deploy Preview https://deploy-preview-1141--zrc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

👋 Hey there!

Thank you for you contribution.

⚠️ Be aware that this PR is not going to trigger a release. ⚠️

Releases and its notes are automatically generated from the commit messages.
If you are expecting a release you will need to modify your commits as stated in the contribution section.

Copy link
Contributor

👋 Hey there!

Thank you for you contribution. Below is a preview of the release notes if your PR gets merged.
Please, make sure it includes all your significant changes with descriptive messages.
Keep in mind that release notes are automatically generated from the commit messages.
More info in the contribution section.


5.72.0 (2024-08-19)

Bug Fixes

Features

@@ -53,6 +54,7 @@ const ErrorMessage = ({ children, className, id, ...rest }: ErrorMessageProps) =
if (theme.errorMessage.iconVariant) {
const iconMap = {
'circle-exclamation': CircleExclamationIcon,
'circle-exclamation2': CircleExclamation2Icon,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can delete all 3 we don't use for this component and leave just a new one?

Copy link
Contributor

👋 Hey there!

Thank you for you contribution. Below is a preview of the release notes if your PR gets merged.
Please, make sure it includes all your significant changes with descriptive messages.
Keep in mind that release notes are automatically generated from the commit messages.
More info in the contribution section.


5.72.0 (2024-08-19)

Bug Fixes

Features

@gbkr gbkr merged commit dcecad7 into master Aug 19, 2024
10 checks passed
@gbkr gbkr deleted the errorMsgIcon2 branch August 19, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants