-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show chapter name when hovering the seekbar #1
Comments
Hmm, I'd definitely be up for showing the chapter in a tooltip above the prev/next chapter buttons. As for the seekbar, would it be okay to only show them as a tooltip over the "chapter tickmarks" if I turn them into buttons? If not, then I guess I can make it a "subtitle" above or below the timestamp tooltip. |
Whether thumbnails can be displayed on the timeline. |
See https://github.com/TheAMM/mpv_thumbnail_script I'm hoping to have playlist thumbnails too so it needs to be semi custom. I might eventually require the upstream mpv_thumbnail_scripts however for now I want to play around with this slow/blocking before adding in async worker scripts. There's also a placeholder for the current chapter (Issue #1) once I've implemented getChapter(videoPercent). I may move the timestamp + chapter text out of the thumbnail frame like how YouTube does it since the chapter can be wider than the thumbnail.
I've a work in progress thumbnail support with the chapter title underneath which looks like YouTube. Once I've polished the Thumbnail generation (based on mpv_thumbnail_script) to always work (currently assumes linux + ffmpeg), I'll merge it. |
The mpv_tethys cache dir was probably not being created for these users as they probably use Windows.
I assume you're on Windows? I forgot to add the Windows "create directory" command, so it was failing to create I've tested Windows in a VM and it seems to work now. |
On windows, the image still doesn't show. the cache folder "mpv_tethys" is empty. |
Don't render again if there's an error the first time. Set mpv thumb msg-level to show errors. Add mpv_thumbnail_script's check_output to print error messages. It also checks if the thumbnail file exists.
Ah, I just noticed the thumb path is I've added a bunch of mpv_thumbnail_script's error handling. Press the `/~ key to open the console and view the logs. |
"mpv.exe" version can display thumbnails normally |
@lyturn Thanks for the update! Does changing Does removing |
Now it works Change preferMpv "true" to "false" , you are awesome. |
... Of course. That makes sense, because the executable is https://github.com/Zren/mpv-osc-tethys/blob/thumb/osc_tethys.lua#L737-L740 Looks like to get
to
It seems I'll need to copy |
Glad you got it working! Once I've finished the mpv/mpvnet check, I'll merge this into master. |
I found that changing preferMpv=true to preferMpvnet=true also works. |
This should fix users who use mpvnet and don't have mpv installed (#1)
Adds PictureInPicture toggle button, which doesn't work well in KDE. Adds Hovered Chapter in Seekbar Tooltip (Issue #1). Seekbar tooltip outline is white like Youtube.
Chapter titles when hovering seekbar is in now merged into the |
as the title, show chapter name when hovering the seekbar, just like the default osc
The text was updated successfully, but these errors were encountered: