This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
When running Nimbus Core on iOS, every property in a Map or Array that was null on Kotlin will be NSNull on Swift. For this reason, we must check for NSNull in some situations instead of just checking for null.
In most of the scenarios where we need to get a value from the property map we also use the class
AnyServerDrivenData
. To fix the issue, I madeAnyServerDrivenData
aware of NSNull, making it treat NSNull just like null.New usages for AnyServerDrivenData
The operations were not using
AnyServerDrivenData
and where it made sense I replaced the direct accesses with it. Where it didn't make sense, I made sureNSNull
was being accounted for.I also replaced
valueOf
in the componentforEach
.Also fixed
IndexOutOfBounds
in many of the operations if the arguments were passed wrong. I fixed it with a proper error message.