This repository has been archived by the owner on Oct 14, 2024. It is now read-only.
fix: TextField rendering #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matheus Ribeiro <matheus.ribeiro@zup.com.br>
uziasferreirazup
approved these changes
Jul 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matheus Ribeiro matheus.ribeiro@zup.com.br
Description
There are some
RenderObjects in Flutter that don't implement thegetDryLayoutmethod, such as theTextFieldwidget, so it wasn't rendered. This PR adds a handle to theRenderMouseRegion, which is theRenderObjectused by theTextFieldwidget.Other considerations
This is not a scalable solution, it may be that other widgets have the same behavior and therefore new fixes will have to be done. However, as the Beagle (the only
yoga_engineuser) has onlyTextFieldwith this behavior, for now this is an acceptable solution.