-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming schema change in id-tagging-schema repository #452
Comments
Hi Martin, thanks for the heads up! It looks like the PR contents are different from what you're writing here: https://github.com/openstreetmap/id-tagging-schema/pull/598/files#diff-9b5f2c6ca12ef16831a653586844a31e069e942d407233afb6ccc6b270782027L2 |
Quick note: the schema (Martin's link) is in a different Repo than the data (your link). Both rely on eachother. |
I know, but the pull request is his, and if it is correct, then the documentation is wrong (and the implementation would be harder). |
Right, the PR in the id-tagging-schema repository was incorrect. For these cross-references, one must use the same identifiers as in the |
Done in 3.1. |
Hi. As you are using the data from the id-tagging-schema repository, I'd like to notify you about some upcoming changes to the json schema used by it. See https://github.com/ideditor/schema-builder/blob/main/CHANGELOG.md#510 and openstreetmap/id-tagging-schema#598.
There are two changes which I would consider breaking:
colour
field type, which should be pretty self-explanatory and can be handled like acombo
field if no dedicated color input method is available or needed.dist/translations
data, and are instead included in thepresets[.min].json
(orfields[.min].json
) and use the same curly-bracket syntax that is used to cross-reference fields of preset (e.g."label": "{building/levels}"
in thebuilding/levels_building
field means that the field should use the same label as thebuilding/levels
field). The following strings can be cross-referenced:name
(if used, this implies thataliases
andterms
should also be used from the other preset)label
(if used, this implies that theterms
should also be used from the other field)placeholder
strings
(which used a dedicated propertystringsCrossReference
in order to keep the schema change to a minimum)Examples:
field
building/levels_building.json
field
payment_multi_fee.json
preset
highway/motorway_link-US-CA.json
This change will likely already affect the next version of released iD presets in a couple of weeks.
The text was updated successfully, but these errors were encountered: