Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor adds "level=0;0" #639

Open
Zverik opened this issue Sep 25, 2023 · 4 comments
Open

Editor adds "level=0;0" #639

Zverik opened this issue Sep 25, 2023 · 4 comments
Labels
bug Something isn't working editor Editor pane, presets and fields
Milestone

Comments

@Zverik
Copy link
Owner

Zverik commented Sep 25, 2023

photo1691000397

@Zverik Zverik added bug Something isn't working editor Editor pane, presets and fields labels Sep 25, 2023
@Zverik Zverik added this to the 3.2 milestone Sep 25, 2023
@Zverik Zverik moved this to Todo in Every Door Sep 25, 2023
@Zverik
Copy link
Owner Author

Zverik commented Sep 28, 2023

I have no idea how this could be, so closing as unreproducible.

@Zverik Zverik closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Every Door Sep 28, 2023
@gdabski
Copy link

gdabski commented Sep 30, 2023

Funny, I found out how to reproduce in 45 seconds ;) There are several different variations, I even managed to create a level=;2 + addr:floor=1;1 situation. The key step seems to be that you initially have to provide addr:floor by typing in the manual editor, return to map by pressing Save, and then reenter the editor and choose another option for level or level + addr:floor from the options that are suggested next to the steps icon (I honestly don't fully understand when these options appear and when not 😅). I'm sure you're figure it out with this hint, but anyway here's one step-by-step description:

  1. Find an amenity with no addr:floor or level tag that already has suggestions for these tags in the main amenity editor screen.
  2. Add value 3 for addr:floor by typing in the manual editor screen addr:floor and level. Observe value 3/ being highlighted next to the steps icon in the amenity editor screen.
  3. Press Save and exit amenity editor.
  4. Enter amenity editor again. Observe value 3/ still being highlighted next to the steps icon in the amenity editor screen.
  5. Choose a suggested /1 option that adds a value for level. Observe /1 being highlighted, but but 3/ being not anymore.
  6. Go to diff/history screen and observe local changes: addr:floor=;3 + level=1.
  7. Choose a suggested /-1 option that adds a value for level. Observe both /-1 and /1 being highlighted (!).
  8. Go to diff/history screen and observe local changes: level=-1;1, addr:floor missing.

@Zverik
Copy link
Owner Author

Zverik commented Sep 30, 2023

This is mind-bending. I'll reopen this, but will come back some other day, with a clear head :)

@Zverik Zverik reopened this Sep 30, 2023
@Zverik Zverik modified the milestones: 4.0, 4.1 Sep 30, 2023
@deevroman
Copy link
Contributor

I even managed to create a level=;2

For clarity:

2023-09-30.22.02.00.mp4

@Zverik Zverik moved this from Done to Todo in Every Door Oct 10, 2023
@Zverik Zverik modified the milestones: 4.2, 5.0 Feb 19, 2024
@Zverik Zverik modified the milestones: 5.0, 5.1 Apr 21, 2024
@Zverik Zverik modified the milestones: 5.2, 6.0 Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working editor Editor pane, presets and fields
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants