Skip to content
This repository has been archived by the owner on Mar 9, 2023. It is now read-only.

Rust: Busway Scheme Refactor #141

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Conversation

droogmic
Copy link
Collaborator

In an attempt to make @BudgieInWA 's PR smaller.

Copy link
Contributor

@dabreegster dabreegster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a step in the right direction and preserving the spirit of the other PR, but big warning, I'm rapidly losing the ability to keep up with what's happening here, so my feedback is not great. :\

pub(in crate::transform::tags_to_lanes) fn from_tags(
tags: &Tags,
locale: &Locale,
oneway: Oneway,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Takes a oneway and then calculates it below?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the oneway coming in is for all vehicles, so I need to first check if there is a value specific for busses.

Now that you mention it, the bus-specific preprocessing should maybe happen one abstraction layer further out, but we can do that later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't read carefully enough. What if we name these road_oneway and bus_oneway?

@droogmic
Copy link
Collaborator Author

Seems like a step in the right direction and preserving the spirit of the other PR, but big warning, I'm rapidly losing the ability to keep up with what's happening here, so my feedback is not great. :\

Yeah, I am just looking for ways to help @BudgieInWA close out his work.

I really want to focus on fixing the widths of small residential roads, but that is mostly dependent on fixing the lane calculation part.

@droogmic droogmic merged commit e741e41 into a-b-street:main Apr 25, 2022
@droogmic droogmic deleted the rust_refactor_busway branch April 25, 2022 16:05
@BudgieInWA
Copy link
Collaborator

Yeah, I am just looking for ways to help @BudgieInWA close out his work.

I really want to focus on fixing the widths of small residential roads, but that is mostly dependent on fixing the lane calculation part.

Thank you, you've done a great job of taking each idea and putting it into context, so that we tackle them independently.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants