-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a step in the right direction and preserving the spirit of the other PR, but big warning, I'm rapidly losing the ability to keep up with what's happening here, so my feedback is not great. :\
pub(in crate::transform::tags_to_lanes) fn from_tags( | ||
tags: &Tags, | ||
locale: &Locale, | ||
oneway: Oneway, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Takes a oneway and then calculates it below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the oneway coming in is for all vehicles, so I need to first check if there is a value specific for busses.
Now that you mention it, the bus-specific preprocessing should maybe happen one abstraction layer further out, but we can do that later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I didn't read carefully enough. What if we name these road_oneway
and bus_oneway
?
Yeah, I am just looking for ways to help @BudgieInWA close out his work. I really want to focus on fixing the widths of small residential roads, but that is mostly dependent on fixing the lane calculation part. |
Thank you, you've done a great job of taking each idea and putting it into context, so that we tackle them independently. |
In an attempt to make @BudgieInWA 's PR smaller.