Content page #30
Merged
Content page #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadolny
commented
Feb 3, 2017
•
mnadolny
commented
- Sidebar styles
- Content template styles
added 30 commits
February 2, 2017 12:33
added 3 commits
February 3, 2017 17:42
ellm
approved these changes
Feb 6, 2017
client/js/app/app.js
Outdated
| import mobileMenu from './mobile-menu'; | ||
|
|
||
| mobileMenu(); | ||
|
|
||
| const hello = 'hello webpack'; | ||
| console.log(hello); |
There was a problem hiding this comment.
Heh, Lines 5 and 6 can probably be removed now
client/js/app/mobile-menu.js
Outdated
| mainNav.classList.remove('active'); | ||
| }); | ||
| } | ||
| console.log('hellhhho'); |
There was a problem hiding this comment.
console.log can probably be removed.
client/sass/_colors.scss
Outdated
| @@ -0,0 +1,5 @@ | |||
| $color-grey: #ccc; | |||
There was a problem hiding this comment.
perhaps #cccccc for consistency
views/pages/index.ejs
Outdated
| @@ -15,7 +16,8 @@ | |||
| </div> | |||
|
|
|||
| </div> | |||
| <div class="jumbotron"> | |||
|
|
|||
| <!-- <div class="jumbotron"> | |||
There was a problem hiding this comment.
Perhaps remove commented code? It can always be referred back to in the git history if needed again.
views/partials/header.ejs
Outdated
| <link rel="stylesheet" href="/bootstrap/css/bootstrap.min.css"> | ||
| <link rel="stylesheet" href="/bootstrap/css/bootstrap-theme.min.css"> | ||
| <!-- <link rel="stylesheet" href="/bootstrap/css/bootstrap.min.css"> | ||
| <link rel="stylesheet" href="/bootstrap/css/bootstrap-theme.min.css"> --> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.