-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content page #30
Content page #30
Conversation
mnadolny
commented
Feb 3, 2017
•
edited
Loading
edited
- Sidebar styles
- Content template styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! A few small comments for your consideration. Also, in general, it might be a good time to convert px
into em
where applicable. Overall 💯
client/js/app/app.js
Outdated
import mobileMenu from './mobile-menu'; | ||
|
||
mobileMenu(); | ||
|
||
const hello = 'hello webpack'; | ||
console.log(hello); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, Lines 5 and 6 can probably be removed now
client/js/app/mobile-menu.js
Outdated
mainNav.classList.remove('active'); | ||
}); | ||
} | ||
console.log('hellhhho'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log
can probably be removed.
client/sass/_colors.scss
Outdated
@@ -0,0 +1,5 @@ | |||
$color-grey: #ccc; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps #cccccc
for consistency
views/pages/index.ejs
Outdated
@@ -15,7 +16,8 @@ | |||
</div> | |||
|
|||
</div> | |||
<div class="jumbotron"> | |||
|
|||
<!-- <div class="jumbotron"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps remove commented code? It can always be referred back to in the git history if needed again.
views/partials/header.ejs
Outdated
<link rel="stylesheet" href="/bootstrap/css/bootstrap.min.css"> | ||
<link rel="stylesheet" href="/bootstrap/css/bootstrap-theme.min.css"> | ||
<!-- <link rel="stylesheet" href="/bootstrap/css/bootstrap.min.css"> | ||
<link rel="stylesheet" href="/bootstrap/css/bootstrap-theme.min.css"> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
peace out Bootstrap, heh