paper cut fixes #239
Merged
paper cut fixes #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bit of a band-aid until we implement a nicer concrete-symbolic API Fixes #220
daejunpark
reviewed
Dec 22, 2023
src/halmos/sevm.py
Outdated
| @@ -253,9 +253,10 @@ def wstore_bytes( | |||
| raise ValueError(size, arr) | |||
| wextend(mem, loc, size) | |||
| for i in range(size): | |||
| if not eq(arr[i].sort(), BitVecSort8): | |||
| arr_i_bv = arr[i] if is_bv(arr[i]) else con(arr[i], 8) | |||
There was a problem hiding this comment.
questions: when arr[i] is not bv:
- do we want to store them as bv, rather than keeping it int?
- do we need to check if arr[i] < 256, or is it guaranteed?
There was a problem hiding this comment.
nice catch, can you check again with 7c5c364?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AttributeError: 'int' object has no attribute 'sort'incall_known#220 (as a band aid until we have a cleaner solution)