Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gemfile #9

Closed
wants to merge 2 commits into from
Closed

Added Gemfile #9

wants to merge 2 commits into from

Conversation

lasseebert
Copy link
Contributor

I was unable to run the tests without a gemfile.

@a2800276
Copy link
Owner

How did you run the tests?

Here, they run fine with rake test under ruby-1.9.3-p448.
They don't run under ruby-2, the mile long stack traces seem to indicate that someone decided to pack yet another kitchen sink into the ruby2 distribution...

Your Gemfile does fix that, but the because of the changed String handling in 2, the tests fail...
And aren't Gemfiles a bundler thing? They seem like unnecessary ballast.

I'll go ahead and merge the other fix, but I'd appreciate it, if you could explain why this is necessary. Sorry.

@a2800276 a2800276 closed this Dec 10, 2014
@lasseebert
Copy link
Contributor Author

I might have confused myself with different versions of ruby and test/unit ;) On 1.9.3 I can run the tests without problems.

Thanks.

@lasseebert lasseebert deleted the gemfile branch September 27, 2015 21:04
ta referenced this pull request Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants