Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature for ViewAngle/Position from engine2.dll: dwEngineViewData #142

Closed
wants to merge 0 commits into from

Conversation

cycript
Copy link
Contributor

@cycript cycript commented Apr 30, 2024

Camera Position and Angles (not ClientViewAngles) are contiguous. (Vec3,Vec3)
Struct that I use:

typedef struct EngineCamera
{
	Vector3 Position;
	Vector3 Rotation;
};

I have been using this for a while now, the signature seems stable.
Sorry for the bad formatting within the signature string.

Copy link
Owner

@a2x a2x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, thanks for the PR.

I've just had a look at this and since these fields are actually within the CSoundService class, I think it would be better to do this instead:

"dwSoundService" => pattern!("488905${'} 4c8d4424? 488d05") => Some(|_view, map, rva| {
    map.insert("dwEngineViewData".to_string(), rva + 0x9C);
}),

It will still produce the same result and is a cleaner solution IMO.

cs2_dumper::analysis::offsets::engine2: found offset: dwEngineViewData @ 0x7FFA5C8FD76C (engine2.dll + 0x5CD76C)
cs2_dumper::analysis::offsets::engine2: found offset: dwSoundService @ 0x7FFA5C8FD6D0 (engine2.dll + 0x5CD6D0)

@cycript
Copy link
Contributor Author

cycript commented May 2, 2024

Looks good to me, I wasn't aware that it was under CSoundService.

@a2x
Copy link
Owner

a2x commented May 3, 2024

Would you be able to make that change and fix the conflicts so that I can merge this?

@cycript
Copy link
Contributor Author

cycript commented May 3, 2024

I am closing this PR and will just make a new one because its more convenient than solving the conflicts

@a2x a2x mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants