Fix "missing" IMDB ID

[kiamvdd]

As mentioned in #78 (comment), xbmc.getInfoLabel('VideoPlayer.IMDBNumber') doesn't always return an IMDB ID even when it is available. Unfortunately despite the provided workaround for this, the problem persists and the addon fails to search for subtitles for certain titles.

I've implemented a possible fix here, replacing the calls to xbmc.getInfoLabel with the new InfoTagVideo API introduced in Kodi v20. InfoTagVideo.getUniqueId does seem to correctly return the IMDB ID for movies when available.

Since it's a new addition to the API this change isn't automatically backwards compatible with v19, so I've also included a version check to maintain said backwards compatibility. I'm not sure if this is the best way to handle this or if might have overlooked anything, so please review.

[9000000]

kodi 21 "IMDB ID not provided" , I have uninstalled kodi and all addons and reinstalled from scratch but still get the error

[newt-sc]

Thanks @kiamvdd. I will look into the new APIs, they should also be mocked in order for the tests to work.

However, for context this is something that depends on the used Video addon.
The label VideoPlayer.IMDBNumber should be set by the Video addon before sending the movie to the video player.
Here for example is how a4kStreaming sets it.

[ChiefVitor]

Thanks @kiamvdd. I will look into the new APIs, they should also be mocked in order for the tests to work.

However, for context this is something that depends on the used Video addon. The label VideoPlayer.IMDBNumber should be set by the Video addon before sending the movie to the video player. Here for example is how a4kStreaming sets it.

Subs from opensubtitles are not working. You can download them, but they don’t play. I already tried a few different movies and tv shows. Always see the same behavior.

[ManilaByNight]

Hi there. I hope you will forgive me for posting this here as I do not know where to post this request and I am a total beginner with this stuff.

Anyway, would it be possible to add a feature to the add-on to have an option to tell the add-on to save the subtitle to a custom location (on the local or network storage location).

Any way to add this feature to this add-on?

Thanks.

[McEnnes]

I also have a problem with the missing IMDB ID in A4Ksubtitles sometimes, but it is not a problem with every show. One of the shows generating this message is: Insomnia (2024)

[newt-sc]

@McEnnes That is because the addon has a fallback when the video addon does not provide the IMDB ID. The addon tries to get it on its own by title searching in IMDB. It does not always work. I will check what is the issue with Insomnia.

@ManilaByNight Yes, we could add that. Just have to find the time. Contributions are welcome. 🙏🏻

[MGuerreiro42]

Hi guys, Im having this problem too this night. I have noticed that the name of the file is showing as url encoded (substituting spaces by %20 to be specific) in the top of the subtitle search menu. This could impact the search?
Currently in a MiBoxS 4k

[twinden]

Looks legit, as the new function does not have the “no IMDb id” issue.

[twinden]

Please merge this into release.
The change looks legit. The “no imdb id” problem can’t get any worse.

[FASOPE]

Hi you all,
I'm having the same issue using the "BBC www" add on. It doesn't find the IMBD id

[newt-sc]

Closing in favor of: #85