-
Notifications
You must be signed in to change notification settings - Fork 1
riscv_dis_shift_xlen_2
Tsukasa OI edited this page Jul 16, 2022
·
6 revisions
- Status: Pending (RFC)
- Branch:
riscv-dis-shift-xlen-2
- Tracking PR: #25 (view Pull Request and Diff)
- Mailing List:
- Not yet
- Pending (RFC): Disassembler: Check shift amount against XLEN (Idea 1)
This is mutually exclusive idea of fixing shift amount issue. -
Disassembler: Fix
printf
types onriscv-dis.c
It also touches the same location. Merging is easy (this patch takes precedence).
Unlike idea 1, conflicts are minimal.
In the disassembler, there's no validation whether shift amount is valid on specific architecture.
Idea 1 patchset fixes that by adding xlen
argument to match_func
(in opcode entries).
Idea 2 patchset (this patchset) fixes that by printing invalid0x[SHAMT]
instead of actual shift width (SHAMT
in hexadecimal).