Added support for authentication with Azure AD #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
a8m
approved these changes
Jun 24, 2021
|
Thank you for the quick review @a8m! Are you also planning a release in the next days? |
a8m
pushed a commit
that referenced
this pull request
Jun 25, 2021
Use an interface for the SP provider object to avoid adding "github.com/Azure/go-autorest/autorest/adal" as a dependency to this module Also, fixed test that was leftover from before. Improves upon #33
|
@a8m do you think you could publish a release in the next few days please? With Go modules, we kind of need a release to pull the latest code :) |
|
Done. Thanks for the reminder and for your contribution 🙏
For next time, you can use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for authenticating with Cosmos DB using Azure AD: https://docs.microsoft.com/en-us/azure/cosmos-db/how-to-setup-rbac
Docs have been updated to provide an example too.