pb: better progress-bar padding #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/pb.rs
Outdated
| .split("") | ||
| .map(|x| x.to_owned()) | ||
| .filter(|x| x != "") | ||
| .collect(); |
There was a problem hiding this comment.
Its not really part of this commit, but this bit of code seems quite odd to me.
src/pb.rs
Outdated
| @@ -347,18 +351,21 @@ impl<T: Write> ProgressBar<T> { | |||
| } | |||
| } | |||
| } | |||
| if !suffix.starts_with(" ") { | |||
| suffix = format!(" {}", suffix); | |||
| } | |||
There was a problem hiding this comment.
I would suggest that instead of this, you remove the space from line 334, and then either unconditionally add the space at line 395 or when you create the string at line 326.
a8m
force-pushed
the
fix/pad-suffix
branch
2 times, most recently
from
1e310a7
to
68e6b11
Compare
src/pb.rs
Outdated
| parts.push(format!("{:.0}m", left / 60.)); | ||
| }; | ||
| } | ||
| if parts.len() > 0 { |
There was a problem hiding this comment.
I believe it is recommended to use is_empty() instead of len() > 0. However, I think you could just drop the condition altogether since joining an empty vec will produce an empty string anyways.
winstonewert
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #58
Other formatting changes caused by
cargo fmt.