Prevent implicit return of window.URL function #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the implicit return of window.URL's constructor instead of a simple boolean value for
usermedia-core's test. This is important because the polyfiller looks to see iftestis a function, and if so calls it. The recently released Chrome 53 doesn't allow direct calls to the URL constructor anymore and will throw an error if called directly. So now a lot of people are seeing webshim break and the further load of their JS stack halt.It looks like the call to URL's constructor has been occurring for a little while now but was hidden because the existence of window.URL is still being verified, even though it was also being erroneously called.