Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing unit testing #86

Closed
aaberg opened this issue Apr 8, 2014 · 4 comments
Closed

Missing unit testing #86

aaberg opened this issue Apr 8, 2014 · 4 comments
Assignees
@dimzon
Labels
priority-high
Milestone
1.5.0

Comments

@aaberg
Copy link
Owner

aaberg commented Apr 8, 2014

We are missing test-coverage for the reflection setter classes:

  • org.sql2o.reflection.FieldSetter
  • org.sql2o.reflection.MethodSetter
  • org.sql2o.reflection.ReflectionFieldSetterFactory
  • org.sql2o.reflection.ReflectionMethodSetterFactory
  • org.sql2o.reflection.ReflectionObjectConstructorFactory
@aaberg aaberg added this to the 1.5.0 milestone Apr 8, 2014
@dimzon
Copy link
Contributor

dimzon commented Apr 8, 2014

I can do it. Anyone else?
I really miss issue assigned to feature like in other bug|request tracking systems... So I can't see somebody already working on it... There are Assignee on the right but I can't assign myself so I think other developers except maybe @aaberg can't too...

@aldenquimby
Copy link
Contributor

@dimzon there is an "issue assigned to" feature, but it's only for repository collaborators. @aaberg would need to add to the repo

dimzon added a commit to dimzon/sql2o that referenced this issue Apr 9, 2014
@dimzon
ref aaberg#86 - more unit tests
c81658d
@dimzon
Copy link
Contributor

dimzon commented Apr 9, 2014

done

aaberg added a commit that referenced this issue Apr 9, 2014
@aaberg
Merge pull request #91 from dimzon/fix-issue-86
9d753f7 
ref #86 - more unit tests
@aaberg
Copy link
Owner Author

aaberg commented Apr 9, 2014

Fixed by @dimzon with pull request #91

@aaberg aaberg closed this as completed Apr 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimzon dimzon

Labels
priority-high
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
3 participants
@aaberg @dimzon @aldenquimby