Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add repeat forever option #72

Merged
merged 2 commits into from
May 17, 2020
Merged

Conversation

yiminghan
Copy link
Contributor

Pull Request Process

  1. Ensure any install or build dependencies are removed before the end of the layer when doing a build.
  2. Update the README.md if needed with details of changes to the interface, this includes new environment variables, exposed ports, useful file locations and container parameters.
  3. Increase the version numbers in any examples files and the README.md to the new version that this Pull Request would represent. The versioning scheme we use is SemVer.
  4. You may merge the Pull Request in once you have the sign-off of one developer, or if you do not have permission to do that, you may request the second reviewer to merge it for you.

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #72 into master will decrease coverage by 0.96%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   64.01%   63.04%   -0.97%     
==========================================
  Files           7        7              
  Lines         653      663      +10     
==========================================
  Hits          418      418              
- Misses        235      245      +10     
Impacted Files Coverage Δ
lib/src/colorize.dart 72.09% <0.00%> (-1.72%) ⬇️
lib/src/fade.dart 56.52% <0.00%> (-1.26%) ⬇️
lib/src/rotate.dart 60.00% <0.00%> (-1.07%) ⬇️
lib/src/scale.dart 61.16% <0.00%> (-1.22%) ⬇️
lib/src/typewriter.dart 47.57% <0.00%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a759eb9...ec57762. Read the comment docs.

@aagarwal1012
Copy link
Owner

@AadumKhor, this PR looks good to me. Can you also share your opinions?

@AadumKhor
Copy link
Collaborator

@aagarwal1012 I was going to address this issue in my next PR. My approach however was removing the count factor when isRepeatingAnimation is true i.e. repeating the animation forever without involving any additional parameter since I agree with what is suggested in #66 .

I like the approach used in this PR as well since it maintains the way our package is used currently and at the same time allows more customization. Personally I like the former approach since repeating animation is this particular use case should not be restricted by count. Also this might help in resolving #52 since we are not keeping track of count anymore which might be causing the problem.

@yiminghan
Copy link
Contributor Author

@AadumKhor My main consideration here is that there's no unexpected breaking changes for current users, since if we change the behaviour of isRepeatingAnimation it's going to require a lot of existing users to change their code.

@aagarwal1012
Copy link
Owner

@yiminghan, your argument seems right to me. @AadumKhor, should I merge this PR and make a new release?

@AadumKhor
Copy link
Collaborator

@aagarwal1012 We can add this to the new release as suggested.

@aagarwal1012 aagarwal1012 merged commit 72229de into aagarwal1012:master May 17, 2020
@AadumKhor AadumKhor mentioned this pull request May 19, 2020
@aagarwal1012
Copy link
Owner

@allcontributors add @yiminghan for feature enhancement.

@allcontributors
Copy link
Contributor

@aagarwal1012

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@aagarwal1012
Copy link
Owner

@allcontributors add @yiminghan for Ideas & Planning.

@allcontributors
Copy link
Contributor

@aagarwal1012

I've put up a pull request to add @yiminghan! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants