Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit hooks #40

Closed
Tracked by #35
mdbenito opened this issue May 27, 2022 · 3 comments
Closed
Tracked by #35

Add pre-commit hooks #40

mdbenito opened this issue May 27, 2022 · 3 comments
Labels
accepted This enhancement or bug report has been accepted as valid enhancement New feature or request
Milestone
Scaffolding

Comments

@mdbenito
Copy link
Collaborator

mdbenito commented May 27, 2022 •
edited
Loading

pre-commit is in use for black + isort.

More?
@mdbenito mdbenito mentioned this issue May 27, 2022
Closed
11 tasks
@mdbenito mdbenito changed the title pre-commit hooks Add pre-commit hooks May 27, 2022
@mdbenito mdbenito added this to the Scaffolding milestone May 27, 2022
@mdbenito mdbenito added the enhancement New feature or request label May 27, 2022
@AnesBenmerzoug
Copy link
Collaborator

AnesBenmerzoug commented May 31, 2022 •
edited
Loading

Maybe enabling black for notebooks too by replacing id: black with id: black-jupyter ?

@mdbenito
Copy link
Collaborator Author

mdbenito commented Jun 1, 2022 •
edited
Loading

Maybe enabling black for notebooks too by replacing id: black with id: black-jupyter ?

Maybe, but then we need to move as much boilerplate out of the notebooks as possible. Black just wastes way too much vertical space and it can be a real PITA to scroll through long notebooks.

To that avail: what about a "setup()" function that imports everything needed into the global scope, maybe even parametrise it or whatever. It's ugly, but it keeps generated docs lean. It's just an idea...

@mdbenito mdbenito added the accepted This enhancement or bug report has been accepted as valid label Jun 15, 2022
@AnesBenmerzoug
Copy link
Collaborator

I think we can consider this done for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted This enhancement or bug report has been accepted as valid enhancement New feature or request
Projects
None yet
Milestone
Scaffolding
Development

No branches or pull requests
2 participants
@mdbenito @AnesBenmerzoug